Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record_type to publications #1102

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fjorba
Copy link
Contributor

@fjorba fjorba commented May 14, 2021

Add the same field as in sources, as it will be needed as we will create
different templates. Please note that:

  1. At this moment there is yet no use for this field. This will come
    later.
  2. I haven't attached the db/schema.rb file in this patch due to a
    conflict. This is my first migration and I'm unsure how to proceed, but
    fortunately db/schema.rb is (re)generated automatically after performing
    'rails db:migrate', so please do this step for me. Thanks.

Add the same field as in sources, as it will be needed as we will create
different templates.  Please note that:

1.  At this moment there is yet no use for this field.  This will come
later.
2.  I haven't attached the db/schema.rb file in this patch due to a
conflict.  This is my first migration and I'm unsure how to proceed, but
fortunately db/schema.rb is (re)generated automatically after performing
'rails db:migrate', so please do this step for me.  Thanks.
@fjorba fjorba changed the title Add record_type do publications Add record_type to publications May 14, 2021
@fjorba
Copy link
Contributor Author

fjorba commented May 14, 2021

Part of #1028

@fjorba fjorba marked this pull request as draft May 14, 2021 08:18
As publication model now has record_type, it needs a method to respond to
get_record_type, otherwise records cannot be edited.  At this moment it is
just empty.
@fjorba fjorba marked this pull request as ready for review May 15, 2021 04:56
@fjorba fjorba marked this pull request as draft February 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant