Allow different templates for secondary literature #1043
Conversation
This patch is the second version of the first step towards having different templates for secondary literature. It synchronises some code and configuration files from sources so now, when creating a new record, appears a menu with a single choice, the legacy template. This version takes into account the catalogues to publications rename and it adds the locale entries compatible with the i18n reorganisation. There are yet no new fields (like record type) or tag changes.
|
This patch updates and replaces #1017. |
config/locales/de.yml
Outdated
| @@ -246,6 +246,9 @@ de: | |||
| individual_entry_threatise_printed: "Theoreticum, gedruckt - Teileintrag der Sammlung" | |||
| single_threatise_printed: "Theoreticum, gedruckt - Individualeintrag" | |||
|
|
|||
| legacy_templates: "LEGACY TEMPLATES" | |||
There was a problem hiding this comment.
We are trying to not put "placeholders" in the language files, so every new entry should be translated into its appropriate language before being added.
There was a problem hiding this comment.
I just followed @xhero advice: #1017 (comment)
So, which is the preferred way now?
| @@ -1,14 +1,14 @@ | |||
| ActiveAdmin.register Publication do | |||
|
|
|||
There was a problem hiding this comment.
Having these changes in this patch makes it difficult to review this change.
There was a problem hiding this comment.
I understand, but Emacs strips those extra spaces for me. In fact, there are so many in Muscat that it is difficult for me to stop Emacs to strip them everywhere else. Shouldn't be a policy in Muscat, like in other projects, to strip them before commiting upstream? I know that there are git hooks for that.
There was a problem hiding this comment.
On the other hand, I have just seen that from the Github web interface it is possible to hide whitespace changes, using the icon in the middle of the Review changes button line.
|
May I do anything to help the approval of this patch? |
|
Sorry! I'm a bit late on this track, I will follow a review shortly! |
|
Everything in the patch seems ok to me, for the moment we can keep then placeholder since they are in the "interface" language file. |
It's requested in #1028 (I've also put some other requests on hold, because maybe there are better solutions). |
|
ok, for the moment I would add a record_type as you suggest, I can also rename title to description |
|
Could you also add |
|
Sorry for the silence - I had to take a small detour for other projects, I will add those fields in 7.1 (and in the next dev branch) so we can merge this. |
|
Can I do anything else for this (and my other pending PR) to be included upstream, @xhero? I'm applying those patches to my sites for each new Muscat release, and we are using them daily (although not in production yet). Thanks. |
Generic is more... generic, and doesn't imply obsolescence.
This patch is the second version of the first step towards having different
templates for secondary literature. It synchronises some code and
configuration files from sources so now, when creating a new record, appears
a menu with a single choice, the legacy template.
This version takes into account the catalogues to publications rename and it
adds the locale entries compatible with the i18n reorganisation.
There are yet no new fields (like record type) or tag changes.