Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the issue of actor migration panic caused by the in-place scale-down (#20316) #20388

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: Fix the issue of actor migration panic caused by the in-place scale-down (#20316) #20388

merged 1 commit into from
Feb 5, 2025

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Feb 5, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@shanicky shanicky requested a review from yezizp2012 February 5, 2025 06:26
tabVersion
tabVersion approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@shanicky shanicky enabled auto-merge February 5, 2025 06:27
@shanicky shanicky force-pushed the peng/cherry-pick-20316 branch from ccf0c46 to c1da990 Compare February 5, 2025 06:39
@shanicky shanicky force-pushed the peng/cherry-pick-20316 branch from c1da990 to 6b124b4 Compare February 5, 2025 06:40
@shanicky shanicky linked an issue Feb 5, 2025 that may be closed by this pull request
cherry-pick fix: Fix the issue of actor migration panic caused by the in-place scale-down (#20316) to branch release-2.1 #20325
Closed
@shanicky shanicky added this pull request to the merge queue Feb 5, 2025
@graphite-app graphite-app bot requested a review from lmatz February 5, 2025 06:48
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 5, 2025

Graphite Automations

"release branch request review" took an action on this PR • (02/05/25)

1 reviewer was added to this PR based on xxchan's automation.

Merged via the queue into release-2.1 with commit f670200 Feb 5, 2025
16 of 28 checks passed
@shanicky shanicky deleted the peng/cherry-pick-20316 branch February 5, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabVersion tabVersion tabVersion approved these changes

@yezizp2012 yezizp2012 yezizp2012 approved these changes

@lmatz lmatz Awaiting requested review from lmatz

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests type/fix Bug fix
Projects
None yet
Milestone
No milestone
3 participants
@shanicky @tabVersion @yezizp2012