Conversation
luhenry
added a commit
that referenced
this pull request
Sep 11, 2026
…tools//platforms verified against the real labmaze checkout at LABMAZE_REF; @bazel_tools no longer bundles a platforms package, so //bazel:linux/apple/windows fail to resolve on any current bazel release before riscv64 detection is reached.
…checkout dir Both wrote to /work/wheelhouse(_repaired) while the upload and test-install steps read from /work/labmaze/wheelhouse(_repaired) -- the build itself now succeeds (bazel/BUILD fix worked) but the artifact was never where later steps looked for it.
…-files glob Build and all 16 tests already pass -- this was the last remaining check, a stale expected-license-set assertion that predated seeing the real wheel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
labmaze1.0.6Compiles DeepMind Lab's text maze generator, two small pybind11 extensions over a C++ core built with Bazel. Upstream publishes no riscv64 wheel.
Upstream ships no CI at all (no
.github/workflows/), so this drives itssetup.py's ownBazelExtensionbuild (pip wheel .) directly instead of mirroring a recipe that doesn't exist.Differs from upstream
build-array-record.yml.WORKSPACE- upstream's pin predates Python 3.12 support.Testing
testGoldenTwoRoom9x11MazeandtestGoldenMazeRegeneration- golden-output tests that fail on any toolchain newer than upstream's own (seeconda-forge/labmaze-feedstock), not riscv64-specific.assertRaisesRegexp->assertRaisesRegex- alias removed in Python 3.12.License: Wheel bundles LICENSE.abseil-cpp and LICENSE.pybind11 (both Apache-2.0/BSD) alongside labmaze's own Apache-2.0 LICENSE, since the extension statically links both.
Patches
0001-WORKSPACE-bump-vendored-pybind11...patch- To upstream [no commits since 2022-11-03, issue scikit-image riscv64 support #5 unanswered since 2023; can't file PRs against third-party repos]. Without it, cp312+ fails to compile.0002-random_maze_test-use-assertRaisesRegex...patch- To upstream [same]. Without it,testInvalidArgumentserrors on 3.12+.Built on cp312; TBD passed, TBD skipped.