lib: sbi_domain: Fix PMP condition for addresses #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to put an address/size into an NAPOT PMP region, the address needs to be aligned to the size shifted two to the right. Example: fw_start: 0x80040000 fw_size: 0x00040000 PMP address: 0x80040000 | (0x00040000 >> 2) fw_size is valid, but not in the current implementation Signed-off-by: Maximilian Brune <[email protected]>
|
We have mailing list based patch review so it would be great if you can send these patchs to OpenSBI mailing list. You need to join OpenSBI mailing list using following link Make sure you use "git send-email" to send the patches. Regards, |
|
Sorry I didn't know that. I will send the patch via email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to put an address/size into an NAPOT PMP region, the address needs to be aligned to the size shifted two to the right.
Example:
fw_start: 0x80040000
fw_size: 0x00040000
PMP address: 0x80040000 | (0x00040000 >> 2)
fw_size is valid, but not in the current implementation
Fixes issue #345