RISC-V Semihosting 2 of 3: Refactor magic sequence detection #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMatCodasip
changed the title
|
Note: This MR is built on top of #1198. |
aap-sc
requested changes
Jan 10, 2025
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-2-refactor-magic-seq-detection
branch
2 times, most recently
from
eeedccd to
d0165b4
Compare
en-sc
requested changes
Jan 15, 2025
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-2-refactor-magic-seq-detection
branch
from
d0165b4 to
df49067
Compare
Refactor (clean up) the code in riscv_semihosting.c by moving the magic sequence detection to its own function. Cleanup the debug prints denoting the semihosting outcome so that they are easier to understand when reading the OpenOCD's verbose (debug) log. Use le_to_h_u32() to convert memory buffer to instruction code because RISC-V instructions are always little endian. (target_buffer_get_u32() was incorrect for that reason.) Change-Id: I3a3ce991336ceeeff023d459d0e28558059554e0 Signed-off-by: Jan Matyas <[email protected]>
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-2-refactor-magic-seq-detection
branch
from
df49067 to
8c0a1cd
Compare
en-sc
approved these changes
Jan 20, 2025
aap-sc
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor (clean up) the code in riscv_semihosting.c by moving
the magic sequence detection to its own function.