Don't do shallow clones if upstream does not support this #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we changes our cloning strategy to do shallow clones only, all CI builds broke because the upstream servers don't allow us to clone specific commits. The error reads like this: error: Server does not allow request for unadvertised object beb2cdbcda911764b2bed5e57921fe90493260bd fatal: Fetched in submodule path 'binutils', but it did not contain beb2cdbcda911764b2bed5e57921fe90493260bd. Direct fetching of that commit failed. What we could do is to search for our target commit in remote branches, fetch those and then checkout our target commit. See also the following comment for an idea how this could be realized: https://github.com/riscv-collab/riscv-gnu-toolchain/ issues/1654#issuecomment-2591195261 However, it feels wrong to do add such scripts downstream. We need to find a better solution. But unless we have one, let's just disable shallow clones to unbreak the CI builds. Signed-off-by: Christoph Müllner <[email protected]>
|
What I still don't know is:
|
Doesn't @mickflemm explain the issue clearly here? |
|
Most GNU toolchain are hosted in |
Sorry, I should have tagged the PR with RFC. So, the only path forward seems indeed to be a downstream clone script (with inspiration from #1616 and #1654 (comment)). Volunteers are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changes our cloning strategy to do shallow clones only, all CI builds broke because the upstream servers don't allow us to clone specific commits. The error reads like this:
See also: https://github.com/riscv-collab/riscv-gnu-toolchain/actions/runs/13434377368/job/37533209677?pr=1677
What we could do is to search for our target commit in remote branches, fetch those and then checkout our target commit. See also the following comment for an idea how this could be realized:
#1654 (comment)
However, it feels wrong to do add such scripts downstream. We need to find a better solution. But unless we have one, let's just disable shallow clones to unbreak the CI builds.