-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wrapped error that includes path #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jdanford ,
Thank you very much for your proposal, this will allow to close a long standing issue.
I added a few comments to the code review, with some required changes and open questions where your feedback would be appreciated.
Thank you very much in advance !
Also can you format the code with |
Alright, made all those changes. Using |
Use thiserror to reduce code maintenance. Use a wrapped error to maintain API compatibility in further evolutions.
Works for me! |
Closes #3