Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapped error that includes path #7

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

jdanford
Copy link
Contributor

Closes #3

Copy link
Owner

@ririsoft ririsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jdanford ,

Thank you very much for your proposal, this will allow to close a long standing issue.
I added a few comments to the code review, with some required changes and open questions where your feedback would be appreciated.

Thank you very much in advance !

Cargo.toml Outdated Show resolved Hide resolved
src/error.rs Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
@ririsoft
Copy link
Owner

Also can you format the code with cargo fmt so that the CI/CD runs OK ?

@jdanford
Copy link
Contributor Author

Alright, made all those changes. Using thiserror sounds fine, it's your project so I'll let you make that call.

@ririsoft ririsoft changed the base branch from master to errortype March 31, 2024 10:02
Use thiserror to reduce code maintenance.
Use a wrapped error to maintain API compatibility in further evolutions.
@ririsoft ririsoft changed the base branch from errortype to master April 2, 2024 08:54
@ririsoft
Copy link
Owner

ririsoft commented Apr 2, 2024

Hello @jdanford, I pushed to your branch a new version using thiserror . Does it matches your expectations ?

@jdanford
Copy link
Contributor Author

jdanford commented Apr 2, 2024

Works for me!

@ririsoft ririsoft merged commit c5fea26 into ririsoft:master Apr 2, 2024
@ririsoft
Copy link
Owner

ririsoft commented Apr 2, 2024

Thank you @jdanford for your contribution. I will release soon, once I also close #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include path information in items
2 participants