387. First Unique Character in a String #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nktr-cp
reviewed
May 21, 2025
| - c++での実装、ただ眺めていた | ||
|
|
||
| - https://github.com/mura0086/arai60/pull/19/files#diff-5ec7c3c87171edf4d61e9eb79fd926cafa27caf068da7474222897c8e9e7ab96 | ||
| - [lru_cache](https://docs.python.org/ja/3.13/library/functools.html#functools.lru_cache)(Least Recently Used cache)という概念を初めて知った. |
There was a problem hiding this comment.
LRUはOSのページングシステム，CPUやディスクのキャッシュの勉強をしていてもみかけるアルゴリズムだと思うので，覚えておいてもいいかもしれないです
| continue | ||
| j = i + 1 | ||
| is_repeat = False | ||
| while(j < len(s)): |
There was a problem hiding this comment.
このwhileはfor j in range(i + 1, len(s))にしたいと思いました
There was a problem hiding this comment.
そうですね, なぞにfor文とwhile文が混ざっていますね. 統一するように意識したいと思います
tokuhirat
reviewed
May 21, 2025
| is_repeat = True | ||
| j += 1 | ||
|
|
||
| if is_repeat is False: |
There was a problem hiding this comment.
その発想は持っていませんでした、 確かに使えますね. ありがとうございます
tokuhirat
reviewed
May 21, 2025
| continue | ||
| j = i + 1 | ||
| is_repeat = False | ||
| while(j < len(s)): |
oda
reviewed
May 22, 2025
Comment on lines
+12
to
+20
| j = i + 1 | ||
| is_repeat = False | ||
| while(j < len(s)): | ||
| if s[j] == s[i]: | ||
| is_repeat = True | ||
| j += 1 | ||
|
|
||
| if is_repeat is False: | ||
| return i |
There was a problem hiding this comment.
ここの部分、find に start をつけたものと同じではないでしょうか。
https://docs.python.org/3/library/stdtypes.html#str.find
(時々ライブラリーを確認してみましょう。)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.