Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

add rpm dependencies to build on centOS7 #71

Merged
merged 4 commits into from Jul 26, 2017
Merged

add rpm dependencies to build on centOS7 #71

merged 4 commits into from Jul 26, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2017

Updating setup.cfg so that the rpm has proper requirements.

It is tested in a docker environment by successfully running "ringo-admin --help".

  • pyramid-mailer in that specific version was introduced in setup.py a few months ago.
  • About XlsxWriter I am not sure; that package built with this name on my setup.

Maximilian Krambach added 2 commits July 19, 2017 11:13
afaik it existed as "XlsxWriter" during my first test in epel?
Now it doesn't exist anymore, and it needs to be custom-build anyhow,
so better stick to naming conventions
@toirl toirl requested review from toirl and gsiv and removed request for toirl July 19, 2017 11:45
@ghost
Copy link
Author

ghost commented Jul 19, 2017

Regarding invoke, see also #72

@toirl
Copy link
Member

toirl commented Jul 19, 2017

@gsiv can you please take a look on the changes.

It should be a separate discussion whether it is needed,
so we shouldn't include it right now.
@gsiv
Copy link
Contributor

gsiv commented Jul 19, 2017

The python-pyramid-mailer version looks good.

  • python2-future: As far as I can tell, there is no such dependency in
    setup.py. If it is indeed a dependency it should be added in both places.

    On our CentOS7 systems python2-future is not installed but future
    (future-0.15.2-2.el7.noarch) is. The packages seem to provide different
    versions of the same library for some reason. Therefore, the version in
    setup.py should precisely match the EPEL version.

  • pytz: Is this a new dependency? I'm unaware of this library and we have
    used Ringo without it until now. It is also not listed in setup.py.

    If we do need to add it and build the RPM ourselves, let's call it
    python-pytz.

@ghost
Copy link
Author

ghost commented Jul 19, 2017

I am very confused now, as my setup should be more or less the same as yours.

pytz: introduced into ringo with commit a58f82b (May 2017). It is a pre-existing package in most distributions (including CentOS)

  • future is indeed something I cannot find anymore in my ringo dependency. I'll look into why I did include it.

@ghost
Copy link
Author

ghost commented Jul 19, 2017

the xlsxwriter problem was due to a typo during package building (in which my package used the default values instead of the ones I gave it).

@ghost
Copy link
Author

ghost commented Jul 19, 2017

About the future:
I cannot grasp the exact position in my stack where the future is needed, in the end my project wants some future.
As there seems to be no future here, I shall look elsewhere.

(Strangely, my install of CentOS 7, which should be quite similar to yours, only sees python-future, and no future)

edit: terrible pun, also it is ringo-admin complaining. If you already have some kind of future, it is expected that there is no error, but it does not seem to be a standard install on a fresh centOS.

@ghost
Copy link
Author

ghost commented Jul 26, 2017

After discussion:
future is only in alembic/env.py and not used there anymore. So we don't really need future. (see my latest commit)

@toirl toirl merged commit b24bcac into ringo-framework:master Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants