Add key-fn library wide #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weavejester
requested changes
Oct 14, 2020
src/ring/middleware/json.clj
Outdated
| @@ -46,6 +46,7 @@ | |||
|
|
|||
| Accepts the following options: | |||
|
|
|||
| :key-fn - fn that will be applied to each key | |||
There was a problem hiding this comment.
Use "function" in the docs instead of "fn".
src/ring/middleware/json.clj
Outdated
| (if valid? (assoc-json-params request json)) | ||
| [request options] | ||
| (if-let [[valid? json] (read-json request options)] | ||
| (when valid? (assoc-json-params request json)) |
There was a problem hiding this comment.
Don't change lines unrelated to the changes in the PR.
src/ring/middleware/json.clj
Outdated
| @@ -130,6 +132,8 @@ | |||
|
|
|||
| Accepts the following options: | |||
|
|
|||
| :date-format - an optional date format string that Date objects will be encoded with | |||
There was a problem hiding this comment.
This line shouldn't be here, right?
test/ring/middleware/test/json.clj
Outdated
| (let [request {:headers {"content-type" "application/json; charset=UTF-8"} | ||
| :body (string-input-stream "{\"foo\": \"bar\"}") | ||
| :params {"id" 3}} | ||
| handler (wrap-json-params identity {:key-fn (fn [k] (.toUpperCase (name k)))}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempt to solve these problems: #62 #51