Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix motherduck duckdb model executor #6943

Merged
merged 1 commit into from
Mar 22, 2025
Merged

fix motherduck duckdb model executor #6943

merged 1 commit into from
Mar 22, 2025

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Mar 21, 2025

This is in continuation of this PR. Fixing models as well.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Mar 21, 2025
@k-anshul k-anshul requested a review from pjain1 March 21, 2025 06:55
Args []any `mapstructure:"args"`
// InitQueries are queries that are run during initialisation of write handle before model is created of any pre_exec queries are run.
InitQueries string `mapstructure:"init_queries"`
PreExec string `mapstructure:"pre_exec"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is pre_exec run before run every query?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No only before the model query is run.

@k-anshul k-anshul merged commit a47991b into main Mar 22, 2025
11 checks passed
@k-anshul k-anshul deleted the fix_md_me branch March 22, 2025 07:14
k-anshul added a commit that referenced this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants