Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chart field name with numbers or special character #6938

Merged
merged 2 commits into from
Mar 22, 2025
Merged

fix: chart field name with numbers or special character #6938

merged 2 commits into from
Mar 22, 2025
+8 −1

Conversation

djbarnwal
Copy link
Member

https://www.notion.so/rilldata/Expression-parse-error-in-charts-1b4ba33c8f57803797bdd38d5c830e6d

Fix expression parse error when variable starts with a special character or number.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@djbarnwal djbarnwal self-assigned this Mar 20, 2025
@djbarnwal djbarnwal merged commit 141acf3 into main Mar 22, 2025
9 checks passed
@djbarnwal djbarnwal deleted the fix/chart-field-name branch March 22, 2025 16:11
djbarnwal added a commit that referenced this pull request Mar 22, 2025
@djbarnwal
fix: chart field name with numbers (#6938)
c7e699c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangregoryholmes briangregoryholmes briangregoryholmes approved these changes

Assignees

@djbarnwal djbarnwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djbarnwal @briangregoryholmes