New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (Banners): Banners were not getting properly removed #6936

Open

ericpgreen2 wants to merge 2 commits into main from fix-remove-banner-reactivity

+4 −4

Contributor

ericpgreen2 commented Mar 20, 2025

The problem was apparent when navigating from a Public URL (with the "Limited View" banner) to the original dashboard.

Checklist:

Covered by tests
Ran it and it works as intended
Reviewed the diff before requesting a review
Checked for unhandled edge cases
Linked the issues it closes
Checked if the docs need to be updated
Intend to cherry-pick into the release branch
I'm proud of this work!

ericpgreen2 added 2 commits

March 20, 2025 10:07


          Fix remove-banner reactivity

1b96dfe


          Update BillingBannerID to billing

161ad90

ericpgreen2 requested a review from AdityaHegde

March 20, 2025 09:10

ericpgreen2 self-assigned this

AdityaHegde approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet