Update Go actions to use go.mod for versioning and adjust depth

.github/workflows/go-cover.yml

@@ -11,18 +11,12 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-go@v5
+    - name: Check out code
+      uses: actions/checkout@v4
+    - name: Set up Go
+      uses: actions/setup-go@v5
       with:
         go-version: 1.23
-    - uses: actions/checkout@v4
-    - uses: actions/cache@v4
-      with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
     - name: Go test with coverage
       run: |-
         # Build list of packages to include in coverage, excluding generated code in 'proto/gen'

.github/workflows/go-lint.yml

@@ -14,7 +14,8 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - name: Check out code
+        uses: actions/checkout@v4
       - name: Set up Go
         uses: actions/setup-go@v5
         with:

.github/workflows/go-test.yml

@@ -10,18 +10,12 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-go@v4
+    - name: Check out code
+      uses: actions/checkout@v4
+    - name: Set up Go
+      uses: actions/setup-go@v5
       with:
         go-version: 1.23
-    - uses: actions/checkout@v4
-    - uses: actions/cache@v4
-      with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
     - name: Go fmt
       run: test -z $(gofmt -l .)
     - name: Go test

.github/workflows/rill-cloud.yml

@@ -28,7 +28,7 @@ jobs:
           fetch-tags: true
 
       - name: Set up Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
 

.github/workflows/web-test-e2e.yml

@@ -96,16 +96,6 @@ jobs:
         with:
           go-version: 1.23
 
-      - name: go build cache
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-          key: ${{ runner.os }}-go-${{ hashFiles('./go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-go-
-
       - name: Build and embed static UI
         if: matrix.name == 'web-local'
         run: PLAYWRIGHT_TEST=true make cli

admin/server/rbac_test.go

@@ -819,6 +819,7 @@ func TestRBAC(t *testing.T) {
 			Domain:       "whitelist-projs.test",
 			Role:         database.ProjectRoleNameAdmin,
 		})
+		require.NoError(t, err)
 
 		// Check we can't whitelist the same domain on the same project again
 		_, err = c1.CreateProjectWhitelistedDomain(ctx, &adminv1.CreateProjectWhitelistedDomainRequest{

admin/server/util_test.go

@@ -84,7 +84,6 @@ func newTestServer(t *testing.T) *Server {
 
 	// Sender
 	sender := email.NewTestSender()
-	require.NoError(t, err)
 	emailClient := email.New(sender)
 
 	// Application-managed column encryption keyring

runtime/connections.go

@@ -196,6 +196,9 @@ func (r *Runtime) Catalog(ctx context.Context, instanceID string) (drivers.Catal
 }
 
 func (r *Runtime) ConnectorConfig(ctx context.Context, instanceID, name string) (*ConnectorConfig, error) {
+	r.instanceMu.RLock()
+	defer r.instanceMu.RUnlock()
+
 	inst, err := r.Instance(ctx, instanceID)
 	if err != nil {
 		return nil, err

runtime/pkg/graceful/grpc.go

@@ -2,18 +2,25 @@ package graceful
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net"
 	"strings"
+	"time"
 
 	"google.golang.org/grpc"
 )
 
+const grpcShutdownTimeout = 15 * time.Second
+
 // ServeGRPC serves a GRPC server and performs a graceful shutdown if/when ctx is cancelled.
 func ServeGRPC(ctx context.Context, server *grpc.Server, port int) error {
+	var lis net.Listener
+	var err error
+
 	// Calling net.Listen("tcp", ...) will succeed if the port is blocked on IPv4 but not on IPv6.
 	// This workaround ensures we get the port on IPv4 (and most likely also on IPv6).
-	lis, err := net.Listen("tcp4", fmt.Sprintf(":%d", port))
+	lis, err = net.Listen("tcp4", fmt.Sprintf(":%d", port))
 	if err == nil {
 		lis.Close()
 		lis, err = net.Listen("tcp", fmt.Sprintf(":%d", port))
@@ -25,17 +32,27 @@ func ServeGRPC(ctx context.Context, server *grpc.Server, port int) error {
 		return err
 	}
 
-	cctx, cancel := context.WithCancel(ctx)
-	var serveErr error
+	// Channel to signal server has stopped
+	serveErrCh := make(chan error)
 	go func() {
-		serveErr = server.Serve(lis)
-		cancel()
+		err := server.Serve(lis)
+		serveErrCh <- err
 	}()
 
-	<-cctx.Done()
-	if serveErr == nil {
+	// Wait for context to be cancelled or failure to serve
+	select {
+	case err := <-serveErrCh:
+		return err
+	case <-ctx.Done():
 		server.GracefulStop()
 	}
 
-	return serveErr
+	// Wait for graceful shutdown
+	select {
+	case err := <-serveErrCh:
+		return err
+	case <-time.After(grpcShutdownTimeout):
+		server.Stop()
+		return errors.New("grpc graceful shutdown timed out")
+	}
 }

runtime/pkg/graceful/http.go

@@ -19,6 +19,8 @@ type ServeOptions struct {
 
 // ServeHTTP serves a HTTP server and performs a graceful shutdown if/when ctx is cancelled.
 func ServeHTTP(ctx context.Context, server *http.Server, options ServeOptions) error {
+	var err error
+
 	// Calling net.Listen("tcp", ...) will succeed if the port is blocked on IPv4 but not on IPv6.
 	// This workaround ensures we get the port on IPv4 (and most likely also on IPv6).
 	lis, err := net.Listen("tcp4", fmt.Sprintf(":%d", options.Port))
@@ -33,26 +35,39 @@ func ServeHTTP(ctx context.Context, server *http.Server, options ServeOptions) e
 		return err
 	}
 
-	cctx, cancel := context.WithCancel(ctx)
-	var serveErr error
+	// Channel to signal server has stopped
+	serveErrCh := make(chan error)
+	// Start server in a goroutine
 	go func() {
 		if options.CertPath != "" && options.KeyPath != "" {
-			serveErr = server.ServeTLS(lis, options.CertPath, options.KeyPath)
+			// Use HTTPS if cert and key are provided
+			err = server.ServeTLS(lis, options.CertPath, options.KeyPath)
+			serveErrCh <- err
 		} else {
-			serveErr = server.Serve(lis)
+			// Otherwise use HTTP
+			err = server.Serve(lis)
+			serveErrCh <- err
 		}
-
-		cancel()
 	}()
 
-	<-cctx.Done()
-	if serveErr == nil {
-		// server.Serve always returns a non-nil err, so this must be a cancel on the parent ctx.
-		// We perform a graceful shutdown.
-		ctx, cancel := context.WithTimeout(context.Background(), httpShutdownTimeout)
-		defer cancel()
-		serveErr = server.Shutdown(ctx)
+	// Wait for context cancellation or server stopped
+	select {
+	case err := <-serveErrCh:
+		return err
+	case <-ctx.Done():
+		if err := server.Close(); err != nil {
+			return err
+		}
 	}
 
-	return serveErr
+	// Wait for graceful shutdown
+	select {
+	case err := <-serveErrCh:
+		return err
+	case <-time.After(httpShutdownTimeout):
+		if err := server.Close(); err != nil {
+			return err
+		}
+		return fmt.Errorf("http graceful shutdown timed out")
+	}
 }

runtime/runtime.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"sync"
 	"time"
 
 	runtimev1 "github.com/rilldata/rill/proto/gen/rill/runtime/v1"
@@ -42,6 +43,7 @@ type Runtime struct {
 	connCache      conncache.Cache
 	queryCache     *queryCache
 	securityEngine *securityEngine
+	instanceMu     sync.RWMutex
 }
 
 func New(ctx context.Context, opts *Options, logger *zap.Logger, st *storage.Client, ac *activity.Client, emailClient *email.Client) (*Runtime, error) {
@@ -177,6 +179,9 @@ func (r *Runtime) UpdateInstanceWithRillYAML(ctx context.Context, instanceID str
 // UpdateInstanceConnector upserts or removes a connector from an instance
 // If connector is nil, the connector is removed; otherwise, it is upserted
 func (r *Runtime) UpdateInstanceConnector(ctx context.Context, instanceID, name string, connector *runtimev1.ConnectorSpec) error {
+	r.instanceMu.Lock()
+	defer r.instanceMu.Unlock()
+
 	inst, err := r.Instance(ctx, instanceID)
 	if err != nil {
 		return err

runtime/server/queries_metrics_comparison_toplist_test.go

@@ -168,10 +168,10 @@ func TestServer_MetricsViewComparison_inline_measures(t *testing.T) {
 }
 
 func TestServer_MetricsViewComparison_nulls(t *testing.T) {
+	t.Parallel()
 	// NOTE: Unstable due to sleep. Commenting until we support configuring settings at instance create time.
 	t.Skip()
 
-	t.Parallel()
 	server, instanceId := getMetricsTestServer(t, "ad_bids_2rows")
 
 	// TODO: Support configuring at create time