allow sending reports to external users with magic tokens

[pjain1]

Fixes #5273

• UI changes needs to be done to handle the new external urls for opening and exporting report containing magic token as path param. Urls for existing users will work as it is.

Clean up of unused magic tokens for reports directly created in code (not through UI) needs to be done. Its a bit tricky, may be some background job is required that queries report_tokens table and for each report_name queries the runtime and then does clean up.

[begelundmuller]

LGTM!

[begelundmuller]

Also note the merge conflict

[pjain1]

@AdityaHegde @ericpgreen2 does the UI changes need review or are we good to merge ?

[ericpgreen2]

@AdityaHegde @ericpgreen2 does the UI changes need review or are we good to merge ?

I took a quick look & looks pretty good, but I'll do a final review tomorrow.

[ericpgreen2]

UXQA:

• For a specific report, my report is blank...
  (Expected) When I click on the email's "Open in browser", I see this data:
  
  (Expected) When I export this data from the dashboard directly, I see:
  
  (Unexpected) When I click on the email's "Download CSV file", I see:
  

• For a project member, I clicked the "Open in browser" link, and I hit this type error. I haven't been able to consistently reproduce this, but it did happen once.
  

• We're missing the bottom border underneath the top bar:
  
  

[pjain1]

@ericpgreen2 for the empty download whats the url ? is it missing the execution_time query param, I cannot reproduce that on my setup.

[ericpgreen2]

@ericpgreen2 for the empty download whats the url ? is it missing the execution_time query param, I cannot reproduce that on my setup.

Download URL: http://localhost:3000/ericpgreen2/rill-test-covid/-/reports/test-external-recipient-asian-vaccinations-63894747/export?execution_time=2024-10-23T14%3A30%3A00Z&format=EXPORT_FORMAT_CSV

In case it helps to repro, here's my project: https://github.com/ericpgreen2/rill-test-covid

[pjain1]

@ericpgreen2 I think its because the watermark used to run this report is trigger time and that is used in time filter so there won't be any data. I confirmed this was the behaviour is past as well. I think if we configure watermark_inherit to true then it should use the actual data to figure out watermark but I don't think its configurable through UI.

[ericpgreen2]

@ericpgreen2 I think its because the watermark used to run this report is trigger time and that is used in time filter so there won't be any data. I confirmed this was the behaviour is past as well. I think if we configure watermark_inherit to true then it should use the actual data to figure out watermark but I don't think its configurable through UI.

Ah! Makes sense!

[pjain1]

Once @ericpgreen2 is ok with the frontend changes, I will resolve the conflicts and merge the PR.

[ericpgreen2]

LGTM