add visibility actions for measures and dimensions

web-common/src/features/dashboards/state-managers/actions/dimensions.ts

@@ -14,11 +14,32 @@ export const setPrimaryDimension = (
   }
 };
 
+export const toggleDimensionVisibility = (
+  { dashboard }: DashboardMutables,
+
+  dimensionName: string,
+) => {
+  const deleted = dashboard.visibleDimensionKeys.delete(dimensionName);
+
+  if (!deleted) {
+    dashboard.visibleDimensionKeys.add(dimensionName);
+  }
+};
+
+export const setVisibleDimensions = (
+  { dashboard }: DashboardMutables,
+  dimensions: string[],
+) => {
+  dashboard.visibleDimensionKeys = new Set(dimensions);
+};
+
 export const dimensionActions = {
   /**
    * Sets the primary dimension for the dashboard, which
    * activates the dimension table. Setting the primary dimension
    * to undefined closes the dimension table.
    */
   setPrimaryDimension,
+  toggleDimensionVisibility,
+  setVisibleDimensions,
 };

web-common/src/features/dashboards/state-managers/actions/index.ts

@@ -13,6 +13,7 @@ import type {
   DashboardUpdaters,
 } from "./types";
 import { dimensionActions } from "./dimensions";
+import { measureActions } from "./measures";
 import { comparisonActions } from "./comparison";
 import { dimensionFilterActions } from "./dimension-filters";
 
@@ -55,6 +56,11 @@ export const createStateManagerActions = (
      */
     dimensions: createDashboardUpdaters(actionArgs, dimensionActions),
 
+    /**
+     * Actions related to measures.
+     */
+    measures: createDashboardUpdaters(actionArgs, measureActions),
+
     /**
      * Common filter actions
      */

web-common/src/features/dashboards/state-managers/actions/measures.ts

@@ -0,0 +1,25 @@
+import type { DashboardMutables } from "./types";
+
+export const toggleMeasureVisibility = (
+  { dashboard }: DashboardMutables,
+
+  measureName: string,
+) => {
+  const deleted = dashboard.visibleMeasureKeys.delete(measureName);
+
+  if (!deleted) {
+    dashboard.visibleMeasureKeys.add(measureName);
+  }
+};
+
+export const setVisibleMeasures = (
+  { dashboard }: DashboardMutables,
+  measureNames: string[],
+) => {
+  dashboard.visibleMeasureKeys = new Set(measureNames);
+};
+
+export const measureActions = {
+  setVisibleMeasures,
+  toggleMeasureVisibility,
+};

web-common/src/features/dashboards/state-managers/selectors/dimensions.ts

@@ -3,18 +3,17 @@ import type { DashboardDataSources } from "./types";
 
 export const allDimensions = ({
   metricsSpecQueryResult,
-}: DashboardDataSources): MetricsViewSpecDimensionV2[] | undefined => {
+}: DashboardDataSources) => {
   return metricsSpecQueryResult.data?.dimensions;
 };
 
 export const visibleDimensions = ({
   metricsSpecQueryResult,
   dashboard,
-}: DashboardDataSources): MetricsViewSpecDimensionV2[] => {
-  const dimensions = metricsSpecQueryResult.data?.dimensions?.filter(
+}: DashboardDataSources) => {
+  return metricsSpecQueryResult.data?.dimensions.filter(
     (d) => d.name && dashboard.visibleDimensionKeys.has(d.name),
   );
-  return dimensions === undefined ? [] : dimensions;
 };
 
 export const dimensionTableDimName = ({

web-common/src/features/dashboards/state-managers/selectors/measures.ts

@@ -9,19 +9,17 @@ import type { DashboardDataSources } from "./types";
 
 export const allMeasures = ({
   metricsSpecQueryResult,
-}: DashboardDataSources): MetricsViewSpecMeasureV2[] => {
-  const measures = metricsSpecQueryResult.data?.measures;
-  return measures === undefined ? [] : measures;
+}: DashboardDataSources) => {
+  return metricsSpecQueryResult.data?.measures;
 };
 
 export const visibleMeasures = ({
   metricsSpecQueryResult,
   dashboard,
-}: DashboardDataSources): MetricsViewSpecMeasureV2[] => {
-  const measures = metricsSpecQueryResult.data?.measures?.filter(
+}: DashboardDataSources) => {
+  return metricsSpecQueryResult.data?.measures.filter(
     (d) => d.name && dashboard.visibleMeasureKeys.has(d.name),
   );
-  return measures === undefined ? [] : measures;
 };
 
 export const getMeasureByName = (