Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bookmarks and filter menus #5732

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

refactor: bookmarks and filter menus #5732

wants to merge 9 commits into from

Conversation

briangregoryholmes
Copy link
Contributor

No description provided.

@briangregoryholmes briangregoryholmes self-assigned this Sep 19, 2024
This was referenced Sep 19, 2024
Draft
Merged
@jkhwu
Copy link
Contributor

jkhwu commented Sep 19, 2024

Hi Brian I took a quick look and the basic functionality looks good, here are a couple notes:

  1. The "save filters only" toggles seems to always revert to off
  2. I managed to enter this state (where I tried to set a custom comparison
    Screenshot 2024-09-19 at 2 11 46 PM
    but there was no calendar). I can't seem to reproduce this but maybe you'll know the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briangregoryholmes briangregoryholmes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briangregoryholmes @jkhwu