Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regex: and expr: selectors for dimension and measure names #5729

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Sep 18, 2024

This PR adds support for selecting dimension and measure names in Explore resources using a regular expression or DuckDB column selector.

Example:

type: explore
metrics_view: my_metrics
dimensions:
  regex: "^external_.*$"
measures:
  expr: "* EXCLUDE (internal_col)"

This works together with the exclude support. For example:

type: explore
metrics_view: my_metrics
dimensions: '*'
measures:
  exclude:
    regex: "^internal_.*$"

Implements this PRD and closes #5712.

@begelundmuller begelundmuller self-assigned this Sep 18, 2024
@begelundmuller begelundmuller marked this pull request as ready for review September 19, 2024 14:42
@k-anshul k-anshul merged commit c5eee0c into main Sep 30, 2024
10 checks passed
@k-anshul k-anshul deleted the begelundmuller/support-regex-and-duckdb-dimension-measure-selectors branch September 30, 2024 16:47
k-anshul pushed a commit that referenced this pull request Oct 15, 2024
#5729)

* Support `regex:` and `expr:` selectors for dimension and measure names

* Regen protos

* DuckDB expressions support

* Tests!

* Test exclude

* Fix lint?

* Revert lint config change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DuckDB COLUMNS syntax for selecting dimensions and measures in explores
2 participants