Migrate metrics_view
to explore
resources (breaking)
#5722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is finished but awaiting frontend refactors.
This PR contains migrations and breaking API changes for the separation of
metrics_view
andexplore
resources. It should not be merged until the frontend has transitioned to consumingexplore
resources. It also requires the frontend to be adapted for the changed API signatures.While this PR would break the current frontend, it does not contain any changes that are incompatible with previous CLI versions. So it is safe to merge once the frontend has been adapted for its changes.
Changes:
version: 1
to the metrics view YAML generator.kind="rill.runtime.v1.MetricsView"
to havekind="rill.runtime.v1.Explore"
.resource_type
andresource_name
properties instead ofmetrics_view
. Specifically, the changes are:resource_type
: new field (set torill.runtime.v1.Explore
for existing rows)resource_name
: renamed frommetrics_view
filter
: renamed frommetrics_view_filter
fields
: renamed frommetrics_view_fields
metrics_view_
prefix for thefilter
andfields
properties. The changesresource_type="rill.runtime.v1.MetricsView"
.GetIFrame
RPC to use atype
parameter instead ofkind
since we prefer "type" in user-facing fields.GetIFrame
RPC to default totype="rill.runtime.v1.Explore"
instead oftype="rill.runtime.v1.MetricsView"
.Frontend integration notes: