Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sorting icon in pivot table #5695

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Sep 13, 2024

closes #5428

This PR adds a desc sorting icon to the sorted first dimension and tweaks the delayed loading rows.

@ericpgreen2
Copy link
Contributor

I should've commented on the original issue, but these unset states feel a little funky to me. The data is always sorted somehow, so IMO we should always indicate how the data is sorted.

In the leaderboard case, it looks like the "unset" case is for the dimensional values to be sorted alphabetically Z->A. We should indicate that & we should make it possible to sort the data A->Z. (Well, this is possible today by entering into the Dimension Detail Table.)

In the pivot case, it looks like the "unset" case is for the data to be sorted by the measure in descending order. I would rather we indicate that than not.

But that's just my opinion! I'll defer to Product on the call. If this is the way we want to go, it looks well implemented :).

@jkhwu
Copy link
Contributor

jkhwu commented Sep 16, 2024

I greenlit the original suggestion to unset a sort in Pivot (#5428), where the initial state has no arrow indicating sort (perhaps it should have an arrow on the totals column).

But on leaderboards, the UX is different, because the default sort should be the value column, and reverting to a default of alphabetical sort doesn't serve much use. You could argue that one shouldn't really ever need to see a leaderboard sorted by anything other than value.

Seeking input from @mindspank and @ericokuma . We could either get rid of the unsetting function altogether, or keep it but communicate the default sort state better.

@ericokuma
Copy link

Is this a valid use case: "I would like to see my customers in ASC order on the leaderboard regardless of value"?

Feels like one but just wanted to double check with folks here

@ericpgreen2
Copy link
Contributor

Is this a valid use case: "I would like to see my customers in ASC order on the leaderboard regardless of value"?

I think it's a valid use case to sort alphabetically by dimension values. It's very closely related to wanting to search for a dimension value.

I'm just not confident that this functionality belongs on a "leaderboard" (in which case the word "leaderboard" kind of loses its meaning), and maybe we should just keep it on the expanded Dimension Detail Table.

@lovincyrus
Copy link
Contributor Author

@lovincyrus lovincyrus changed the title Ability to unset column sorting Delayed loading rows Sep 17, 2024
@lovincyrus lovincyrus changed the title Delayed loading rows Sorting Indicator Sep 17, 2024
@lovincyrus lovincyrus changed the title Sorting Indicator Show sorting icon in pivot table Sep 17, 2024
@lovincyrus
Copy link
Contributor Author

Latest demo:

CleanShot.2024-09-17.at.14.58.40.mp4

@ericpgreen2
Copy link
Contributor

Two things possibly related:

  1. I'm frequently hitting a bug when I put a dimension and a measure in the Columns section
  2. I'm not seeing a sort arrow when I have a dimension and measure in the Columns section (even when the bug is not triggered)
image

@lovincyrus lovincyrus force-pushed the cyrus/sorting-unset branch 2 times, most recently from 2313686 to aa0b57c Compare September 24, 2024 01:02
@lovincyrus lovincyrus marked this pull request as draft October 1, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to unset column sorting
4 participants