-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sorting icon in pivot table #5695
base: main
Are you sure you want to change the base?
Conversation
I should've commented on the original issue, but these unset states feel a little funky to me. The data is always sorted somehow, so IMO we should always indicate how the data is sorted. In the leaderboard case, it looks like the "unset" case is for the dimensional values to be sorted alphabetically Z->A. We should indicate that & we should make it possible to sort the data A->Z. (Well, this is possible today by entering into the Dimension Detail Table.) In the pivot case, it looks like the "unset" case is for the data to be sorted by the measure in descending order. I would rather we indicate that than not. But that's just my opinion! I'll defer to Product on the call. If this is the way we want to go, it looks well implemented :). |
I greenlit the original suggestion to unset a sort in Pivot (#5428), where the initial state has no arrow indicating sort (perhaps it should have an arrow on the totals column). But on leaderboards, the UX is different, because the default sort should be the value column, and reverting to a default of alphabetical sort doesn't serve much use. You could argue that one shouldn't really ever need to see a leaderboard sorted by anything other than value. Seeking input from @mindspank and @ericokuma . We could either get rid of the unsetting function altogether, or keep it but communicate the default sort state better. |
Is this a valid use case: "I would like to see my customers in ASC order on the leaderboard regardless of value"? Feels like one but just wanted to double check with folks here |
I think it's a valid use case to sort alphabetically by dimension values. It's very closely related to wanting to search for a dimension value. I'm just not confident that this functionality belongs on a "leaderboard" (in which case the word "leaderboard" kind of loses its meaning), and maybe we should just keep it on the expanded Dimension Detail Table. |
Reverted and addressed the changes based on https://rilldata.slack.com/archives/C01A9DYP013/p1726521277917949?thread_ts=1726269952.735399&cid=C01A9DYP013 @ericpgreen2 |
Latest demo: CleanShot.2024-09-17.at.14.58.40.mp4 |
2313686
to
aa0b57c
Compare
aa0b57c
to
a9b5b78
Compare
closes #5428
This PR adds a desc sorting icon to the sorted first dimension and tweaks the delayed loading rows.