feat : Execute dashboard query as part of health check #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
force-pushed
the
dashboard_queries
branch
from
4d8f059
to
1b01f49
Compare
begelundmuller
requested changes
Sep 19, 2024
Co-authored-by: Benjamin Egelund-Müller <[email protected]>
begelundmuller
requested changes
Oct 4, 2024
Co-authored-by: Benjamin Egelund-Müller <[email protected]>
Co-authored-by: Benjamin Egelund-Müller <[email protected]>
Co-authored-by: Benjamin Egelund-Müller <[email protected]>
k-anshul
force-pushed
the
dashboard_queries
branch
from
ee30fb5
to
f046a64
Compare
begelundmuller
approved these changes
Oct 16, 2024
| CREATE TABLE IF NOT EXISTS instance_health ( | ||
| instance_id TEXT PRIMARY KEY, | ||
| health BLOB NOT NULL, | ||
| created_on TIMESTAMP NOT NULL, |
There was a problem hiding this comment.
Should this be named updated_on? Since it changes when the health is updated. (It probably doesn't make sense to have a separate created_on field as it would just be roughly the same as that of the instance in the instances table.)
There was a problem hiding this comment.
Yes. Forgot to update the db column names here. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/rilldata/rill-private-issues/issues/640