-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deploy): UI based user invite #5176
Conversation
This popover is appearing on the wrong page :) It's currently appearing on the Dashboard Share page
|
web-admin/src/features/projects/user-invite/UserInviteForm.svelte
Outdated
Show resolved
Hide resolved
@ericokuma Thanks for the UX pass. I will update the location of the share button and the popover. Regarding the dropdown for role, where are the designs for it? I am referring to https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7/RILL?node-id=6801-232076&t=Dp2SPeOU2RW3lVMh-0 and they dont have the dropdown icon and they say Also not sure what |
36ed7ff
to
7e8cb38
Compare
Ah @jkhwu, would you kindly update the mocks to include a version where there is a dropdown selector for role in the invite by email feature? This feature is only available for By Pills, I mean this: Also, please refer to the PRD: https://www.notion.so/rilldata/RD-RC-1-5-UI-Based-User-Project-Invitation-Dashboard-Sharing-826f1d3615f14941935c1d57cf7d8df3?pvs=4 for the details |
@AdityaHegde cc @ericokuma here I've shown the dropdown next to "can view". See the last variant and click into the component to see the hover and active states: https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7/RILL?node-id=13326-670655&t=jQKpt7XXDqz0oS2K-11 |
962c4da
to
ff534f3
Compare
Yes copy link needs this #5198 for it to fully work |
UXQA –
Agree. |
Addressed 1, 2 & 3. For 4, the mocks still have this not sure if intended. For 5, the page is just placeholder. Will update once i integrate with deploy flow. |
The only feedback here is that when a user clicks on "Invite", toast notification is missing. Here's the requirement: https://www.notion.so/rilldata/RD-RC-1-5-UI-Based-User-Project-Invitation-Dashboard-Sharing-826f1d3615f14941935c1d57cf7d8df3?pvs=4#d442dd5e5c8e472081f075311338cf53 |
UXQA –
|
5965f0f
to
98d6618
Compare
closes #5045
This PR adds a popup for adding users.
Also adds basic code for invite after a deploy. The actual implementation might change when integrating with deploy flow.
Note that this doesnt support identifying public/private domains of the user.
This also doesnt add the
Request Access
flow or the sharable link flow throughcopy link