Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy): UI based user invite #5176

Merged
merged 20 commits into from
Jul 19, 2024
Merged

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Jul 2, 2024

closes #5045

This PR adds a popup for adding users.
Also adds basic code for invite after a deploy. The actual implementation might change when integrating with deploy flow.

Note that this doesnt support identifying public/private domains of the user.
This also doesnt add the Request Access flow or the sharable link flow through copy link

@AdityaHegde AdityaHegde marked this pull request as ready for review July 3, 2024 15:30
@ericokuma
Copy link

ericokuma commented Jul 3, 2024

This popover is appearing on the wrong page :)
Needs to appear as a popover from the Project Page e.g. https://ui.rilldata.com/demo/my-rill-project

It's currently appearing on the Dashboard Share page

Screenshot 2024-07-03 at 10 13 08 AM

here's the design mock:
image

  • The popover should be right-aligned vertically with the right edge of the share button
Screenshot 2024-07-03 at 10 16 19 AM
  • @jkhwu, the "Share this project" font is much larger than any other font on the page. Should we consider shrinking?

  • @AdityaHegde, we haven't implemented Pills yet right?

  • The role should not be visible in empty state.

  • There's also missing "helper text" in the form. See mock:

Screenshot 2024-07-03 at 10 25 59 AM
  • Also, the role selector should have a dropdown icon indicator in projects that have been Connected to Github and for project_admins
Screenshot 2024-07-03 at 10 17 57 AM Screenshot 2024-07-03 at 10 22 17 AM

Here's the mock: Screenshot 2024-07-03 at 10 23 42 AM

  • The dropdown box should be right-aligned vertically as well

  • We should probably update the options in the dropdown to: 'viewer' and 'admin'

@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Jul 4, 2024

@ericokuma Thanks for the UX pass. I will update the location of the share button and the popover.

Regarding the dropdown for role, where are the designs for it? I am referring to https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7/RILL?node-id=6801-232076&t=Dp2SPeOU2RW3lVMh-0 and they dont have the dropdown icon and they say can view (I extrapolated can edit)

Also not sure what Pill you are referring to.

@AdityaHegde AdityaHegde force-pushed the adtiyahegde/ui-based-user-invite branch from 36ed7ff to 7e8cb38 Compare July 4, 2024 06:37
@ericokuma
Copy link

ericokuma commented Jul 4, 2024

Ah @jkhwu, would you kindly update the mocks to include a version where there is a dropdown selector for role in the invite by email feature? This feature is only available for project_admins on accounts that have Connected to Github

By Pills, I mean this:

Screenshot 2024-07-04 at 9 27 12 AM

Also, please refer to the PRD: https://www.notion.so/rilldata/RD-RC-1-5-UI-Based-User-Project-Invitation-Dashboard-Sharing-826f1d3615f14941935c1d57cf7d8df3?pvs=4 for the details

@jkhwu
Copy link
Contributor

jkhwu commented Jul 9, 2024

@AdityaHegde cc @ericokuma here I've shown the dropdown next to "can view". See the last variant and click into the component to see the hover and active states: https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7/RILL?node-id=13326-670655&t=jQKpt7XXDqz0oS2K-11

@AdityaHegde AdityaHegde force-pushed the adtiyahegde/ui-based-user-invite branch from 962c4da to ff534f3 Compare July 9, 2024 16:07
@AdityaHegde AdityaHegde linked an issue Jul 9, 2024 that may be closed by this pull request
@ericokuma
Copy link

ericokuma commented Jul 9, 2024

  1. The role should appear once user enters at least 1 character
Screenshot 2024-07-09 at 9 56 22 AM
  1. Looks like there's some spacing issue from the pill the role dropdown selector
Screenshot 2024-07-09 at 9 57 11 AM
  1. Copy link will be integrated later?

@AdityaHegde
Copy link
Collaborator Author

Yes copy link needs this #5198 for it to fully work

@ericpgreen2
Copy link
Contributor

UXQA –

  1. Nothing happens when I submit an invalid email address. I'd expect to see an input validation warning.
    image

  2. The input box should not need to expand vertically after adding 1 character.

  3. The input box should not be taller than the "Invite" button
    image

  4. @jkhwu, the "Share this project" font is much larger than any other font on the page. Should we consider shrinking?

Agree.

  1. This page does not match the Figma mocks.
    image

@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Jul 15, 2024

Addressed 1, 2 & 3. For 4, the mocks still have this not sure if intended. For 5, the page is just placeholder. Will update once i integrate with deploy flow.

@ericokuma
Copy link

The only feedback here is that when a user clicks on "Invite", toast notification is missing.

Here's the requirement: https://www.notion.so/rilldata/RD-RC-1-5-UI-Based-User-Project-Invitation-Dashboard-Sharing-826f1d3615f14941935c1d57cf7d8df3?pvs=4#d442dd5e5c8e472081f075311338cf53

@ericpgreen2
Copy link
Contributor

UXQA –

  1. When the form submission errors, we should show it in the dialog
    image

  2. Emails are not included in the payload unless they've been submitted & converted to a pill. CC @ericokuma and @jkhwu for desired behavior. One solution (which we should do regardless) would be to disable the "Invite" button until at least 1 email has been officially added.

    These work:
    image
    image

    These don't work:
    image
    image

@AdityaHegde AdityaHegde force-pushed the adtiyahegde/ui-based-user-invite branch from 5965f0f to 98d6618 Compare July 17, 2024 07:53
@AdityaHegde AdityaHegde merged commit 4df0367 into main Jul 19, 2024
4 checks passed
@AdityaHegde AdityaHegde deleted the adtiyahegde/ui-based-user-invite branch July 19, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: UI-Based User Invitation
4 participants