fix: use ignore_paths while checking large projects during rill start #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/cmd/start/start.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if !info.IsDir() { | ||
| if !info.IsDir() && drivers.IsIgnored(path, ignorePaths) { |
There was a problem hiding this comment.
is tmp directly added to ignorePaths by default during project initialization?
There was a problem hiding this comment.
Yes here is the full list: https://github.com/rilldata/rill/blob/main/runtime/drivers/repo.go#L52
begelundmuller
requested changes
Jul 1, 2024
cli/cmd/start/start.go
Outdated
| } | ||
| } | ||
|
|
||
| err = filepath.Walk(path, func(path string, info os.FileInfo, err error) error { |
There was a problem hiding this comment.
Can you change this to filepath.WalkDir and return filepath.SkipDir if the path is ignored? So that it doesn't spend time traversing ignored directories.
There was a problem hiding this comment.
Good point, updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
ignore_pathswith a few hardcoded paths while reading the project files. But this was missing while we check for large projects duringrill start