New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DuckDB connector form #5162

Open

ericpgreen2 wants to merge 1 commit into main from fix-duckdb-form-validation

Contributor

ericpgreen2 commented Jun 28, 2024 •

edited

Loading

Fix form validation, as raised in Cannot add a DuckDB source (Source Name is Required) #5140
Use ConfigProperties not SourceProperties for OLAP connectors. In DuckDB's case specifically, we should use path not db.
MotherDuck is not currently a Connector, but it can be a Source. Remove reference to it in the DuckDB Connector form.
Use a file picker, not a string input, to select the DuckDB path.


          Fix validation of DuckDB connector form

390f7c7

ericpgreen2 requested a review from k-anshul

June 28, 2024 13:43

ericpgreen2 self-assigned this

ericpgreen2 changed the title ~~Fix validation of DuckDB connector form~~ Fix DuckDB connector form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment