feat: add copy/tooltips to TDD table #5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbarnwal
reviewed
Jun 26, 2024
djbarnwal
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a stopgap solution to enable copying of values via the TDD table. A larger refactor is necessary to remove the use of
RegularTable, but this is a significant lift that is not currently prioritized.This PR moves the responsibility for formatting from the data preparation utilities to the display components.
Tooltips are displayed using the native HTML
titleattribute rather than our bespokeTooltipcomponent as using the latter is not practical with Regular Table and the tooltip approach throughout the app is in flux.Closes: #4490