Runtime: rename source fix for external table storage (#4381)

* rename source fix for external table storage

* temporary fix for external table storage and duckdb external transfers

runtime/drivers/duckdb/olap.go

@@ -448,7 +448,7 @@ func (c *connection) InsertTableAsSelect(ctx context.Context, name string, byNam
 // `DETACH foo__1`
 // `rm foo/1.db`
 func (c *connection) RenameTable(ctx context.Context, oldName, newName string, view bool) error {
-	c.logger.Debug("rename table", zap.String("from", oldName), zap.String("to", newName), zap.Bool("view", view))
+	c.logger.Debug("rename table", zap.String("from", oldName), zap.String("to", newName), zap.Bool("view", view), zap.Bool("ext", c.config.ExtTableStorage))
 	if strings.EqualFold(oldName, newName) {
 		return fmt.Errorf("rename: old and new name are same case insensitive strings")
 	}
@@ -461,9 +461,6 @@ func (c *connection) RenameTable(ctx context.Context, oldName, newName string, v
 		return err
 	}
 	if !exist {
-		if !view {
-			return fmt.Errorf("rename: table %q does not exist", oldName)
-		}
 		return c.dropAndReplace(ctx, oldName, newName, view)
 	}
 

runtime/reconcilers/source.go

@@ -88,8 +88,9 @@ func (r *SourceReconciler) Reconcile(ctx context.Context, n *runtimev1.ResourceN
 	// Handle renames
 	if self.Meta.RenamedFrom != nil {
 		// Check if the table exists (it should, but might somehow have been corrupted)
-		t, ok := olapTableInfo(ctx, r.C, src.State.Connector, src.State.Table)
-		if ok && !t.View { // Checking View only out of caution (would indicate very corrupted DB)
+		_, ok := olapTableInfo(ctx, r.C, src.State.Connector, src.State.Table)
+		// NOTE: Not checking if it's a view because some backends will represent sources as views (like DuckDB with external table storage enabled).
+		if ok {
 			// Rename and update state
 			err = olapForceRenameTable(ctx, r.C, src.State.Connector, src.State.Table, false, tableName)
 			if err != nil {