Skip to content

Commit

Permalink
Fix alert dialog not getting updated state managers (#5685)
Browse files Browse the repository at this point in the history
  • Loading branch information
AdityaHegde authored and begelundmuller committed Sep 13, 2024
1 parent a6a7d30 commit 717b940
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions web-admin/src/features/navigation/TopNavigationBar.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,17 @@
<UserInviteButton {organization} {project} />
{/if}
{#if (onMetricsExplorerPage && isDashboardValid) || onPublicURLPage}
<StateManagersProvider metricsViewName={dashboard}>
<LastRefreshedDate {dashboard} />
<GlobalDimensionSearch metricsViewName={dashboard} />
{#if $user.isSuccess && $user.data.user && !onPublicURLPage}
<CreateAlert />
<Bookmarks metricsViewName={dashboard} />
<ShareDashboardButton {createMagicAuthTokens} />
{/if}
</StateManagersProvider>
{#key dashboard}
<StateManagersProvider metricsViewName={dashboard}>
<LastRefreshedDate {dashboard} />
<GlobalDimensionSearch metricsViewName={dashboard} />
{#if $user.isSuccess && $user.data.user && !onPublicURLPage}
<CreateAlert />
<Bookmarks metricsViewName={dashboard} />
<ShareDashboardButton {createMagicAuthTokens} />
{/if}
</StateManagersProvider>
{/key}
{/if}
{#if $user.isSuccess}
{#if $user.data && $user.data.user}
Expand Down

2 comments on commit 717b940

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Published on https://ui.rilldata.com as production
🚀 Deployed on https://66e4285fcf851b12e4b556e9--rill-ui.netlify.app

Please sign in to comment.