Change method to resolve HostName #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsciaroni
commented
Mar 1, 2021
Comment on lines
+119
to
+126
|
|
||
| hostPackage=$(dpkg-query -W --showformat='${Status}\n' host 2>/dev/null) | ||
| if [ "x${hostPackage}" != "xinstall ok installed" ]; then | ||
| if apt-get -qq install -y host >/dev/null; then | ||
| echo "Host package installed" | ||
| fi | ||
| fi | ||
|
|
There was a problem hiding this comment.
Add dependency on the host package.
| @@ -457,7 +465,7 @@ chmod a+x /etc/letsencrypt/renewal-hooks/deploy/unifi | |||
| cat > /usr/local/sbin/certbotrun.sh <<_EOF | |||
| #! /bin/sh | |||
| extIP=\$(curl -fs -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/network-interfaces/0/access-configs/0/external-ip") | |||
| dnsIP=\$(getent hosts ${dnsname} | cut -d " " -f 1) | |||
| dnsIP=\$(host ${dnsname} | cut -d " " -f 4) | |||
There was a problem hiding this comment.
Change the method to resolve the hostname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First, can I thank you for creating this script! It is incredibly useful and saved me a lot of time.
I forked your repo because I encountered an error. When I used your script, I was not getting a letsencrypt cert. After looking at the log, I found that the script was resolving the host's IP address to the NIC's "internal" IP address. To get around this, I added the 'host' debian package. After installing this, I simply updated the script to use the new command. I have tested the script and it is working successfully for me.
Please let me know below if you have any questions!
Again, Thank you for all that you have done on this.