Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use playwright instead of testing library and msw #11

Merged
merged 26 commits into from
Mar 6, 2024

Conversation

rifandani
Copy link
Owner

@rifandani rifandani commented Feb 29, 2024

what's changed

  • uninstalled all previous test related libraries
  • install dotenv and faker js for e2e testing
  • adjust ci workflow

related issues

close #4

checklist

  • e2e login page
  • e2e not found page
  • e2e home page
  • e2e todo list page
  • e2e todo detail page

@rifandani rifandani self-assigned this Feb 29, 2024
@rifandani rifandani added enhancement New feature or request refactor Change in code/folder structure, naming, design pattern labels Feb 29, 2024
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:18am

@rifandani
Copy link
Owner Author

i give up on testing playwright on Github CI. I have tried using microsoft docker container (jammy and focal) and plain normal way (see the commented code in ci.yml).

The errors is timed out failure in the assertions. I suspect it because of the webServer.url or webServer.command. I have tried using

// 3300 when using pnpm dev
// 4173 when using pnpm build-and-preview

const url = http://localhost:3300
const url = http://localhost:4173
const url = http://127.0.0.1:3300
const url = http://127.0.0.1:4173

I suspect the github action runner does not run the local server correctly

@rifandani rifandani merged commit a647116 into main Mar 6, 2024
5 checks passed
@rifandani rifandani deleted the feat/playwright branch March 6, 2024 07:25
@rifandani rifandani mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Change in code/folder structure, naming, design pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright
1 participant