-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
6,089 additions
and
5,114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Issues | ||
|
||
## Issues/improvements I personally encounter when using JollyUI: | ||
|
||
- `date-picker` -> use `@internationalized/date` instead of `date-fns` to format date | ||
- `checkbox` -> `labelVariants` function should be called inside of `cn` -> `labelVariants()` | ||
- `radio-group` -> `labelVariants` function should be called inside of `cn` -> `labelVariants()` | ||
- `searchfield` -> All className should be `(values) => typeof className === 'function' ? className(values) : className` | ||
- `switch` -> `<div className="pointer-events-none block h-5 w-5"` there's no need for `cn` helper. | ||
- `breadcrumbs` -> in `BreadcrumbLink` and `BreadcrumbPage`, className should be `(values) => typeof className === 'function' ? className(values) : className`. | ||
- `Link` we don't need `LinkRenderProps` assertions in className values, it's already inferred | ||
- `tabs` -> `Selected items not found. Exiting.` error. All className should be `(values) => typeof className === 'function' ? className(values) : className` | ||
- `dialog` -> in `DialogContent`, `Modal` className should be `(values) => typeof className === 'function' ? className(values) : className` | ||
- `TextArea` className should be `(values) => typeof className === 'function' ? className(values) : className` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.