Cleanup #8
Open
Cleanup #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t steps are to make a proper Xtend handlebars template
… without crashing. Next steps. Make it run with Siebel pages and maybe polish the generator.js so that it throws less exceptions. The CS selector in the generator.js file is buggy as the css special characters are not escaped properly
…generator.js has a new try catch block and it errors in finding elements don't crash the code. The error is simply printed with console.log.
| @@ -8,7 +8,7 @@ window.POG=(function() { | |||
|
|
|||
| // ======================================================================== | |||
| // private functions | |||
|
|
|||
|
Thank you, @VaccinalBowl. Would you please fill in the CLA located here if you haven't done so: https://goo.gl/forms/Bax4dq33Q7. Thanks. |
|
Hi Richard
I filled in the form and submit it
…On Sat 7. Apr 2018 at 18:38, Richard Huang ***@***.***> wrote:
Thank you, @VaccinalBowl <https://github.com/VaccinalBowl>. Would you
please fill in the CLA located here if you haven't done so:
https://goo.gl/forms/Bax4dq33Q7. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfkjBhiNBTXwFl7gHBlYvWco-F_qwJdks5tmOtrgaJpZM4I22Xs>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I am using your code but I notice some problem in generator.js. I am not sure if it is a bug or not but if so I have fixed an issue.
In the generator.js file some css selectors from the web will cause an exception. I have added a try catch block to catch that and just print with console.log that an error has occur. This has made your code run on much more web pages than before.
I am not sure if this is intentional but maybe you want to pull it to the master repository.