Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some spacing and a border to the blocks. #8

Open
wants to merge 1 commit into
base: v1/dev
Choose a base branch
from

Conversation

AaronSadlerUK
Copy link
Contributor

@AaronSadlerUK AaronSadlerUK commented Feb 3, 2023

I have added a 4px top margin plus a border to make the blocks distinguishable with each other.

image

I was unable to the css stylesheet to load so it's also inline, not sure if that's a limitation of the backoffice?

Fixes #5

@rickbutterfield rickbutterfield changed the base branch from main to develop February 3, 2023 20:38
@rickbutterfield
Copy link
Owner

I'm a little torn on this one - in my opinion the preview should appear as close to the live site as possible but I get the need to be able to see the separation of blocks without having to hover/tab through them.

@rickbutterfield rickbutterfield added the enhancement New feature or request label Mar 24, 2023
@robertjf
Copy link
Contributor

@AaronSadlerUK @rickbutterfield an alternative to this is to add some markup to the Component Views to inject a class based on the IsBlockPreview extension method - that way you can style the padding/margin/border any way you like without having to inject CSS etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block border
3 participants