kill all the jshint error things

.jshintignore

@@ -1,2 +1,2 @@
 **/node_modules
-*.min.js
+test/site

.jshintrc

@@ -6,6 +6,7 @@
   "node": true,
   "quotmark": "single",
   "trailing": true,
+  "expr": true,
   "globals": {
     "$": true,
     "jQuery": true,
@@ -20,6 +21,9 @@
     "h": true,
     "conf": true,
     "document": true,
-    "window": true
+    "window": true,
+    "expect": true,
+    "afterEach": true,
+    "jasmine": true
   }
 }

examples/buster.js

@@ -6,4 +6,4 @@ config['My tests'] = {
     tests: [
         'examples/webdriverjs.with.buster.js'
     ]
-}
+};

examples/cucumber/features/step-definitions.js

@@ -12,7 +12,7 @@
 var webdriverjs = require('../../../index'),
     assert      = require('assert');
 
-var sharedSteps = module.exports = function(){
+module.exports = function(){
 
     var client    = webdriverjs.remote({ desiredCapabilities: {browserName: 'phantomjs'}, logLevel: 'silent' }),
         tmpResult = null;

examples/webdriverio.addCommand.js

@@ -1,12 +1,12 @@
 var webdriverio = require('../index');
-var helper = require('./webdriverio.externalAddCommandHelper')
+var helper = require('./webdriverio.externalAddCommandHelper');
 
 var options = {
     desiredCapabilities: {
         browserName: 'chrome'
     }
 };
-client = webdriverio.remote(options);
+var client = webdriverio.remote(options);
 client.addCommand('searchGoogle',helper.searchGoogle.bind(client));
 
 var SearchString = 'webdriver.io';

examples/webdriverio.multiremote.chat.js

@@ -4,8 +4,7 @@ var WebdriverIO = require('../'),
         browserB: { desiredCapabilities: { browserName: 'firefox' } }
     }),
     browserA = matrix.select('browserA'),
-    browserB = matrix.select('browserB'),
-    name;
+    browserB = matrix.select('browserB');
 
 /**
  * open chat application

examples/webdriverio.multiremote.js

@@ -5,8 +5,8 @@ var WebdriverIO = require('../'),
                 browserName: 'chrome',
                 chromeOptions: {
                     args: [
-                        "use-fake-device-for-media-stream",
-                        "use-fake-ui-for-media-stream",
+                        'use-fake-device-for-media-stream',
+                        'use-fake-ui-for-media-stream',
                     ]
                 }
             }
@@ -16,8 +16,8 @@ var WebdriverIO = require('../'),
                 browserName: 'chrome',
                 chromeOptions: {
                     args: [
-                        "use-fake-device-for-media-stream",
-                        "use-fake-ui-for-media-stream",
+                        'use-fake-device-for-media-stream',
+                        'use-fake-ui-for-media-stream',
                     ]
                 }
             }

examples/webdriverio.selectBy.js

@@ -1,7 +1,6 @@
 /* http://thenostalgiamachine.com/ */
 
-var webdriverio = require('../index'),
-    Q = require('q');
+var webdriverio = require('../index');
 
 var options = {
     desiredCapabilities: {

examples/webdriverio.selectorExecuteAsync.js

@@ -13,7 +13,7 @@ webdriverio
     .timeoutsAsyncScript(5000)
     .selectorExecuteAsync('//div', function(inputs, message, callback){
 
-        setTimeout(callback.bind(null, inputs.length + ' ' + message), 2500)
+        setTimeout(callback.bind(null, inputs.length + ' ' + message), 2500);
 
     }, 'divs on the page')
     .then(function(res){

examples/webdriverio.waitForVisible.js

@@ -1,5 +1,4 @@
-var webdriverio = require('../index'),
-    Q = require('q');
+var webdriverio = require('../index');
 
 var options = {
     desiredCapabilities: {

examples/webdriverio.with.buster.js

@@ -1,9 +1,10 @@
-var buster = require("buster"),
+var buster = require('buster'),
     assert = buster.referee.assert,
-    webdriverio = require('../index');
+    webdriverio = require('../index'),
+    client;
+
+buster.testCase('Nested setup and teardown call order', {
 
-buster.testCase("Nested setup and teardown call order", {
-
     'setUp': function (done) {
         this.timeout = 5000;
         client = webdriverio.remote({ desiredCapabilities: {browserName: 'firefox'} });

examples/webdriverio.with.mocha.and.chai.js

@@ -1,6 +1,5 @@
 var chai        = require('chai'),
     assert      = chai.assert,
-    expect      = chai.expect,
     webdriverio = require('../index');
 
 describe('my webdriverio tests', function(){

examples/webdriverio.with.nodeunit.js

@@ -1,5 +1,5 @@
 var webdriverio = require('../index'),
-    assert      = require('assert');
+    client;
 
 module.exports = {
 

examples/webdriverio.with.vows.js

@@ -1,7 +1,6 @@
 var vows = require('vows'),
     assert = require('assert'),
-    webdriverio = require('../index'),
-    fs = require('fs');
+    webdriverio = require('../index');
 
 var client;
 
@@ -17,17 +16,17 @@ vows.describe('my github tests').addBatch({
 
         'starting webdriverio successfully': {
 
-            topic: function (init) {
+            topic: function () {
                 client.url('https://github.com/', this.callback);
             },
 
             'check logo dimension': {
 
-                topic: function (url) {
+                topic: function () {
                     client.getElementSize('.header-logo-wordmark', this.callback);
                 },
 
-                'getElementSize() should cause no error': function(err,result) {
+                'getElementSize() should cause no error': function(err) {
                     assert(err === null);
                 },
 
@@ -47,7 +46,7 @@ vows.describe('my github tests').addBatch({
                     client.getTitle(this.callback);
                 },
 
-                'getTitle() should cause no error': function(err,result) {
+                'getTitle() should cause no error': function(err) {
                     assert(err === null);
                 },
 
@@ -63,7 +62,7 @@ vows.describe('my github tests').addBatch({
                     client.getCssProperty('a[href="/plans"]', 'color', this.callback);
                 },
 
-                'getElementCssProperty() should cause no error': function(err,result) {
+                'getElementCssProperty() should cause no error': function(err) {
                     assert(err === null);
                 },
 
@@ -80,7 +79,7 @@ vows.describe('my github tests').addBatch({
                 client.end(this.callback);
             },
 
-            'should end successfully': function(err,result) {
+            'should end successfully': function(err) {
                 assert(err === null);
             }
 

index.js

@@ -29,7 +29,7 @@ module.exports.version = package.version;
 module.exports.ErrorHandler = ErrorHandler;
 
 // use the chained API reference to add static methods
-var remote = module.exports.remote = function remote(options) {
+module.exports.remote = function remote(options) {
 
     options = options || {};
 

lib/commands/addValue.js

@@ -42,7 +42,7 @@ module.exports = function addValue (selector, value) {
      * parameter check
      */
     if(typeof value === 'number') {
-      value = '' + value
+      value = '' + value;
     }
 
     if(typeof value !== 'string' && !Array.isArray(value)) {

lib/commands/clearElement.js

@@ -24,9 +24,6 @@ var ErrorHandler = require('../utils/ErrorHandler.js');
 
 module.exports = function clearElement (selector) {
 
-    var self = this,
-        response = {};
-
     return this.elements(selector).then(function(res) {
 
         if(!res.value || res.value.length === 0) {

lib/commands/debug.js

@@ -34,7 +34,7 @@ module.exports = function debug () {
     this.logger.logLevel = 'verbose';
     this.logger.debug();
 
-    rl.question('', function(answer) {
+    rl.question('', function() {
         this.logger.logLevel = logLevel;
         rl.close();
         defer.resolve();

lib/commands/endAll.js

@@ -16,7 +16,7 @@ module.exports = function endAll () {
             sessionCommands = [];
 
         res.value.forEach(function(session) {
-            sessionCommands.push(self.session('delete', session.id))
+            sessionCommands.push(self.session('delete', session.id));
         });
 
         return this.unify(sessionCommands);

lib/commands/getAttribute.js

@@ -48,8 +48,8 @@ module.exports = function getAttribute (selector, attributeName) {
             elementIdAttributeCommands = [];
 
         res.value.forEach(function(elem) {
-            elementIdAttributeCommands.push(self.elementIdAttribute(elem.ELEMENT, attributeName))
-        })
+            elementIdAttributeCommands.push(self.elementIdAttribute(elem.ELEMENT, attributeName));
+        });
 
         return this.unify(elementIdAttributeCommands, true);
 

lib/commands/getCookie.js

@@ -44,7 +44,7 @@ module.exports = function getCookie (name) {
             })[0] || null;
         }
 
-        return res.value || (typeof name === 'string' ? null : [])
+        return res.value || (typeof name === 'string' ? null : []);
 
     });
 

lib/commands/getCssProperty.js

@@ -85,7 +85,7 @@ module.exports = function getCssProperty (selector, cssProperty) {
 
         res.value.forEach(function(elem) {
             elementIdCssPropertyCommands.push(self.elementIdCssProperty(elem.ELEMENT, cssProperty));
-        })
+        });
 
         return Q.all(elementIdCssPropertyCommands);
 

lib/commands/getElementSize.js

@@ -41,10 +41,10 @@ module.exports = function getElementSize (selector, prop) {
             elementIdSizeCommands = [];
 
         res.value.forEach(function(elem) {
-            elementIdSizeCommands.push(self.elementIdSize(elem.ELEMENT))
+            elementIdSizeCommands.push(self.elementIdSize(elem.ELEMENT));
         });
 
-        return Q.all(elementIdSizeCommands)
+        return Q.all(elementIdSizeCommands);
 
     }).then(function(sizes) {
 

lib/commands/getHTML.js

@@ -51,7 +51,7 @@ module.exports = function getHTML(selector, includeSelectorTag) {
 
         // throw NoSuchElement error if no element was found
         if (!html) {
-            err = new ErrorHandler(7);
+            throw new ErrorHandler(7);
         }
 
         return html && html.length === 1 ? html[0] : html;

lib/commands/hold.js

@@ -21,9 +21,6 @@ module.exports = function hold (selector) {
         throw new ErrorHandler.CommandError('hold command is not supported on non mobile platforms');
     }
 
-    var self = this,
-        response = {};
-
     return this.element(selector).then(function(res) {
         return this.touchLongClick(res.value.ELEMENT);
     });

lib/commands/isExisting.js

@@ -37,11 +37,10 @@
  *
  */
 
-var ErrorHandler = require('../utils/ErrorHandler.js');
-
 module.exports = function isExisting (selector) {
 
     return this.elements(selector).then(function(res) {
+
         if(res.value && res.value instanceof Array && res.value.length > 0) {
             return true;
         }

lib/commands/selectorExecuteAsync.js

@@ -47,7 +47,7 @@ var ensureClientS = require('../helpers/ensureClientSideSelectorSupport'),
 module.exports = function selectorExecuteAsync(selector, script) {
     var args = Array.prototype.slice.call(arguments, 2);
 
-    if(typeof selector === "string") {
+    if(typeof selector === 'string') {
         selector = [selector];
     }
 

lib/commands/setViewportSize.js

@@ -26,7 +26,7 @@
  */
 
 
-var getViewportSizeHelper = require('../helpers/_getViewportSize')
+var getViewportSizeHelper = require('../helpers/_getViewportSize'),
     ErrorHandler = require('../utils/ErrorHandler.js');
 
 module.exports = function setViewportSize (size) {

lib/commands/submitForm.js

@@ -25,8 +25,6 @@
  *
  */
 
-var ErrorHandler = require('../utils/ErrorHandler.js');
-
 module.exports = function submitForm (selector) {
 
     return this.element(selector).then(function(res) {

lib/commands/touch.js

@@ -18,9 +18,6 @@ module.exports = function touch (selector) {
         throw new ErrorHandler.CommandError('touch command is not supported on non mobile platforms');
     }
 
-    var self = this,
-        response = {};
-
     return this.getLocation(selector).then(function(val) {
         return this.touchDown(val.x, val.y);
     });