Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rut-graph _init_type() style elsewhere #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Use rut-graph _init_type() style elsewhere #14

wants to merge 7 commits into from

Conversation

ChrisCummins
Copy link
Contributor

On Wed, May 29, 2013 at 06:41:08PM +0100, Bragg, Robert wrote:

> One thing to note when looking at existing components is that none of them
> currently follow the rut-type style that I referred you to in rut-graph so
> if you see the _init_type() function then the vtables may be scattered
> within the C file and we used to have to make lots of manual changes based
> on the name of the type. If you add a new component it would be good if you
> can follow the style in rut-graph.c. If you fancy making a separate patches
> to update any of the other components to follow the newer style too that
> could also be cool :-)

Thought I'd make a start on this to make sure I'm on the right tracks

Chris Cummins added 7 commits July 5, 2013 13:40
pointalism: Use type declaration style of rut-graph
fb5e85c 
rut/rut-graph.c uses a cleaner style of type initialisation which
doesn't require there to be vtables scattered throughout the source
file.
camera: Use type declaration style of rut-graph
38ef1a2 
Same as fb5e85c.
diamond: Use type declaration style of rut-graph
337f08b 
Same as fb5e85c, with one discrepancy - the RutDiamond class is declared
as a RigDiamond in rut_type_init(), so it isn't possible to stringify
the TYPE macro.
light: Use type declaration style of rut-graph
828f84e 
Same as 337f08b.
material: Use type declaration style of rut-graph
12dff02 
Same as 337f08b.
model: Use type declaration style of rut-graph
4880a51 
Same as 337f08b.
shape: Use type declaration style of rut-graph
b25ebd0 
Same as 337f08b.
@ChrisCummins
Copy link
Contributor Author

I suppose these could be squashed together since it's 7 commits doing identical refactors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChrisCummins