Add optional lint to require that actions are pinned to commit hashes #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenson
commented
Jun 24, 2024
| @@ -284,6 +285,10 @@ var BrandingIcons = map[string]struct{}{ | |||
| "zoom-out": {}, | |||
| } | |||
|
|
|||
| var hashRegex = regexp.MustCompile("^[0-9a-f]{40}$") | |||
There was a problem hiding this comment.
You could use short hashes as well, but I was almost certain that would conflict with branch names so this seems better.
ChrisCarini
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Awesome! 🎉 👏
Looking forward to seeing this feature incorporated since it is a recommended 'security hardening' best-practice that GitHub states: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
|
@rhysd what do you think? Viable and/or any changes you'd suggest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the "Pin Actions to a full length commit SHA" part of #198 by optionally enforcing that actions are pinned to (full) commit hashes.
This can be enabled by setting
require-commit-hashtotrueinactionlint.yaml.I haven't contributed to this repo before, so please let me know if you'd like any changes!