-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inline-ignore #375
base: main
Are you sure you want to change the base?
Conversation
someone please merge this PR |
This PR is not acceptable because
The feature requested at #237 is more complicated than it looks actually. |
@rhysd Could you merge this PR?
# actionlint ignore=potentially untrusted
run: |
echo "hello"
echo '${{ github.event.head_commit.author.name }}'
echo "hello" I hope to have a constructive discussion. |
78e9286
to
0b49da7
Compare
Thank you for addressing some of my comments.
That's possible because the error position is poor. I'm sorry that I was not able to describe my concern clearly. For example,
When an error is found at L13, actionlint reports an error happened at L10. So implementation in this branch somehow currently works fine and the ignore comment can remove the error. However, when we improve the error position in the future and actionlint can report an error happened at L13, then this implementation will break. The ignore comment above L10 cannot remove an error at L13. And there is no possible fix in that case. So this implementation happens to work correctly for now, but it's depending on poor error location. Once the poor error location issue is solved, this implementation no longer works. This is what I concern. |
@rhysd I was wondering about the 'poor error location' when I've been using this tool - is there a separate issue tracking that bug/improvement? I'd certainly love to see this improve. My 2 cents on this PR, if this works w/ the current way the error location is reported, I think this is fine, and when the poor error location problem gets addressed, the implementation in this change can be updated to accommodate it as well - what do you think? |
Is there another way to disable checks in the meantime?
The input exists in the composite action but Edit: This turned out to be an issue on my end, never mind. |
add inline-ignore feature.
this resolves #237