fix: [COO-1305] Fix misspelled metric name in accelerators #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the spelling of units of the accellerator temperature.
|
Hi @empovit. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/ok-to-test |
Contributor
|
/lgtm |
empovit
added a commit
to empovit/nvidia-gpu-operator
that referenced
this pull request
Nov 6, 2025
Following rhobs/observability-operator#926, fix the misspelled temperature units in the the metrics translation rules for OpenShift. Signed-off-by: Vitaliy Emporopulo <[email protected]>
jgbernalp
approved these changes
Nov 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: empovit, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jgbernalp
pushed a commit
to jgbernalp/observability-operator
that referenced
this pull request
Nov 7, 2025
Fix the spelling of units of the accellerator temperature.
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
* fix: [COO-1304] Fix misspelled labels of accelerator metrics (#925) Fix misspelled labels in the common accelerator metrics dashboard. * fix: [COO-1305] Fix misspelled metric name in accelerators (#926) Fix the spelling of units of the accellerator temperature. --------- Co-authored-by: Vitaly E. <[email protected]>
github-actions bot
pushed a commit
to NVIDIA/gpu-operator
that referenced
this pull request
Nov 7, 2025
Following rhobs/observability-operator#926, fix the misspelled temperature units in the the metrics translation rules for OpenShift. Signed-off-by: Vitaliy Emporopulo <[email protected]> (cherry picked from commit 5ae72ca)
github-actions bot
pushed a commit
to NVIDIA/gpu-operator
that referenced
this pull request
Nov 10, 2025
Following rhobs/observability-operator#926, fix the misspelled temperature units in the the metrics translation rules for OpenShift. Signed-off-by: Vitaliy Emporopulo <[email protected]> (cherry picked from commit 5ae72ca)
jan--f
added a commit
that referenced
this pull request
Nov 20, 2025
* sync code changes from main to release-1.3 (#918) * fix: fix linter issues and add CI check for linter changes (#887) Since we call `golang-lint --fix` we should check if the linter has fixed anything. Signed-off-by: Jan Fajerski <[email protected]> * build(deps): bump github.com/grafana/tempo-operator (#915) Bumps [github.com/grafana/tempo-operator](https://github.com/grafana/tempo-operator) from 0.16.0 to 0.18.0. - [Release notes](https://github.com/grafana/tempo-operator/releases) - [Changelog](https://github.com/grafana/tempo-operator/blob/main/CHANGELOG.md) - [Commits](grafana/tempo-operator@v0.16.0...v0.18.0) --- updated-dependencies: - dependency-name: github.com/grafana/tempo-operator dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * OU-964: update incidents and TP to GA (#912) * feat: update min version for incident feature to 4.20 * feat: update incidents and tp to GA in matrix * fix: re-enable incidents on 4.19 --------- Co-authored-by: Alberto Falossi <[email protected]> * fix: set 4.19 as GA for incidents (#917) * chore: update korrel8r image to 0.8.4 for COO 1.3 (#908) --------- Signed-off-by: Jan Fajerski <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jan Fajerski <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Yurkovich <[email protected]> Co-authored-by: Alberto Falossi <[email protected]> Co-authored-by: Alan Conway <[email protected]> * fix: reconcile incident related resources only in 4.19+ (#921) * fix: reconcile korrel8r backend only for troubleshooting plugin (#922) Signed-off-by: Gabriel Bernal <[email protected]> * feat: drop korrel8r and troubleshooting panel support before 4.19 (#929) Signed-off-by: Gabriel Bernal <[email protected]> * Sync accelerators fixes (#930) * fix: [COO-1304] Fix misspelled labels of accelerator metrics (#925) Fix misspelled labels in the common accelerator metrics dashboard. * fix: [COO-1305] Fix misspelled metric name in accelerators (#926) Fix the spelling of units of the accellerator temperature. --------- Co-authored-by: Vitaly E. <[email protected]> * fix: rename clusterrolebinding used for monitoring plugin to avoid clash (#931) * Sync release tag (#927) * fix: fix linter issues and add CI check for linter changes (#887) Since we call `golang-lint --fix` we should check if the linter has fixed anything. Signed-off-by: Jan Fajerski <[email protected]> * build(deps): bump github.com/grafana/tempo-operator (#915) Bumps [github.com/grafana/tempo-operator](https://github.com/grafana/tempo-operator) from 0.16.0 to 0.18.0. - [Release notes](https://github.com/grafana/tempo-operator/releases) - [Changelog](https://github.com/grafana/tempo-operator/blob/main/CHANGELOG.md) - [Commits](grafana/tempo-operator@v0.16.0...v0.18.0) --- updated-dependencies: - dependency-name: github.com/grafana/tempo-operator dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * OU-964: update incidents and TP to GA (#912) * feat: update min version for incident feature to 4.20 * feat: update incidents and tp to GA in matrix * fix: re-enable incidents on 4.19 --------- Co-authored-by: Alberto Falossi <[email protected]> * fix: set 4.19 as GA for incidents (#917) * chore: update korrel8r image to 0.8.4 for COO 1.3 (#908) * chore(release): 1.3.0 (#920) --------- Signed-off-by: Jan Fajerski <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Yurkovich <[email protected]> Co-authored-by: Alberto Falossi <[email protected]> Co-authored-by: Alan Conway <[email protected]> * chore: bumpt to prometheus-operator 0.86.2 (#933) Signed-off-by: Jan Fajerski <[email protected]> --------- Signed-off-by: Jan Fajerski <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Gabriel Bernal <[email protected]> Co-authored-by: lihongyan1 <[email protected]> Co-authored-by: Jan Fajerski <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Yurkovich <[email protected]> Co-authored-by: Alberto Falossi <[email protected]> Co-authored-by: Alan Conway <[email protected]> Co-authored-by: Gabriel Bernal <[email protected]> Co-authored-by: Vitaly E. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the spelling of units of the accellerator temperature.