-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub action to test the patches as early and as often as possible #21
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
415856f
tests: remove old tests
coiby 7428f4e
tests: add Test Management Tool kdump NFS tests
coiby 52f33a5
tests: Don't compare vmcore-dmesg.txt for now
coiby fe06faa
tests: set root password to make it easier to troubleshot test failures
coiby ee31867
tests: allow to use custom mirror
coiby 44329e5
tests: install a custom built kdump-utils RPM
coiby 2eb9edc
tests: add local dumping test plan
coiby 803dad4
tests: add SSH dumping test plan
coiby 77f3c85
tests: add NFS early dumping test plan
coiby 010be0f
tests: add LVM2 thin provision dumping test plan
coiby 934f624
tests: enable Github action
coiby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
name: kdump-utils tests | ||
|
||
on: pull_request | ||
|
||
jobs: | ||
format-check: | ||
runs-on: ubuntu-latest | ||
container: docker.io/fedora:latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: dnf install shfmt -y | ||
- run: shfmt -s -d *.sh kdumpctl mk*dumprd tests/*/*/*.sh dracut/*/*.sh tools/*.sh | ||
|
||
static-analysis: | ||
runs-on: ubuntu-latest | ||
container: docker.io/fedora:latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: dnf install shellcheck -y | ||
# Currently, for kdump-utils, there is need for shellcheck to require | ||
# the sourced file to give correct warnings about the checked file | ||
- run: shellcheck -x *.sh spec/*.sh kdumpctl mk*dumprd | ||
- run: shellcheck -x dracut/*/*.sh | ||
- run: shellcheck -x tests/*/*/*.sh tools/*.sh | ||
|
||
unit-tests: | ||
runs-on: ubuntu-latest | ||
container: docker.io/fedora:latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: sudo dnf install -y make dracut grubby hostname | ||
- run: curl -L -O https://github.com/shellspec/shellspec/archive/latest.tar.gz && tar -xzf latest.tar.gz | ||
- run: cd shellspec-latest && sudo make install | ||
- run: shellspec | ||
|
||
integration-tests: | ||
runs-on: self-hosted | ||
timeout-minutes: 45 | ||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.fedora_version }}-${{ matrix.test }} | ||
cancel-in-progress: true | ||
strategy: | ||
matrix: | ||
fedora_version: [ | ||
"40", | ||
] | ||
fail-fast: false | ||
steps: | ||
- name: "Checkout Repository" | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
- name: "${{ matrix.fedora_version }} kdump tests" | ||
run: tools/run-integration-tests.sh ${{ matrix.fedora_version }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Use dracut code style | ||
[*] | ||
shell_variant = bash | ||
indent_style = space | ||
indent_size = 4 | ||
switch_case_indent = true | ||
function_next_line = false | ||
binary_next_line = true | ||
space_redirects = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
1 |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
summary: Kdump local dumping | ||
# Disable this plan due to https://bugzilla.redhat.com/show_bug.cgi?id=2270423 | ||
enabled: false | ||
discover: | ||
how: fmf | ||
test: | ||
- /setup/default_crashkernel | ||
- /setup/trigger_crash | ||
- /tests/check_vmcore/local | ||
|
||
provision: | ||
- name: client | ||
how: virtual | ||
connection: system |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
summary: Kdump LVM2 provision dumping | ||
discover: | ||
how: fmf | ||
test: | ||
- /setup/default_crashkernel | ||
- /setup/lvm2_thinp | ||
- /setup/trigger_crash | ||
- /tests/check_vmcore/lvm2_thinp | ||
|
||
provision: | ||
- name: client | ||
how: virtual | ||
connection: system | ||
hardware: | ||
disk: | ||
- size: = 40GB | ||
- size: = 1GB |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
provision: | ||
- name: server | ||
how: virtual | ||
connection: system | ||
|
||
- name: client | ||
how: virtual | ||
connection: system | ||
|
||
|
||
prepare: | ||
# Set root password to log in as root in the console | ||
- name: Set root password | ||
how: shell | ||
script: | ||
- echo root:kdump | chpasswd | ||
|
||
- name: Use custom mirror | ||
how: shell | ||
script: | ||
- test -v CUSTOM_MIRROR && sed -e 's/^metalink=/#metalink=/g' -e "s|^#baseurl=http://download.example/pub/fedora/linux|baseurl=${CUSTOM_MIRROR}|g" -i.bak /etc/yum.repos.d/fedora*.repo || true | ||
- dnf config-manager --set-disabled fedora-cisco-openh264 || true | ||
|
||
- name: Install built RPM | ||
how: install | ||
package: | ||
- "$KDUMP_UTILS_RPM" | ||
where: | ||
- client | ||
|
||
|
||
execute: | ||
how: tmt | ||
exit-first: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
summary: Kdump NFS dumping tests | ||
discover: | ||
- name: Set up crashkernel | ||
how: fmf | ||
test: | ||
- setup/default_crashkernel | ||
where: | ||
- client | ||
- name: Set up NFS server | ||
how: fmf | ||
test: | ||
- setup/nfs_server | ||
where: | ||
- server | ||
- name: Setup NFS client | ||
how: fmf | ||
test: | ||
# For tmt, nfs means nfs*, so use nfs$ to exclude nfs_early | ||
- setup/network_client/nfs$ | ||
where: | ||
- client | ||
- name: Panic kernel | ||
how: fmf | ||
test: | ||
- /setup/trigger_crash | ||
where: | ||
- client | ||
- name: Check vmcore | ||
how: fmf | ||
test: | ||
- /tests/check_vmcore/nfs | ||
where: | ||
- server |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
summary: Kdump NFS early dumping tests | ||
discover: | ||
- name: Set up crashkernel | ||
how: fmf | ||
test: | ||
- setup/default_crashkernel | ||
where: | ||
- client | ||
- name: Set up NFS server | ||
how: fmf | ||
test: | ||
- setup/nfs_server | ||
where: | ||
- server | ||
- name: Set up NFS client | ||
how: fmf | ||
test: | ||
- setup/network_client/nfs_early | ||
where: | ||
- client | ||
- name: Check vmcore | ||
how: fmf | ||
test: | ||
- /tests/check_vmcore/nfs | ||
where: | ||
- server |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
summary: Kdump SSH dumping tests | ||
discover: | ||
- name: Set up crashkernel | ||
how: fmf | ||
test: | ||
- /setup/default_crashkernel | ||
where: | ||
- client | ||
- name: Set up ssh client | ||
how: fmf | ||
test: | ||
- /setup/network_client/ssh | ||
where: | ||
- client | ||
- name: Panic kernel | ||
how: fmf | ||
test: | ||
- /setup/trigger_crash | ||
where: | ||
- client | ||
- name: Check vmcore | ||
how: fmf | ||
test: | ||
- /tests/check_vmcore/ssh | ||
where: | ||
- server |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In commit message
s/kexec-tools repo/kdump-utils repo/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in new version, thanks!