Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tweaks. Text to speech notifications, icons, overlay battery status icon, etc. #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

uq1
Copy link

@uq1 uq1 commented Sep 7, 2024

  • Changed (unfinished) windows notifications to much more useful SAPI (text to speech) sound notifications, as windows popups are pretty useless inside VR. Very useful for those of us using a Quest/Pico with battery to know when to switch.
  • Added a basic application icon and required resource settings.
  • Added overlay icon showing HMD battery status at all times.
  • Added icon files for the above.
  • Disabled the sockets code (commented out) as it doesn't seem to work and denies connections. I'm not sure this code is even needed, I tend to think sound is the way to go for all notifications.

NOTES:

  • I do not see the overlay when I click the icon (new icon works, just no overlay is displayed), seems to be ImGui/GL/OpenVR versions texture issue? I did not see the overlay even before starting my changes. If I tell it to draw the battery instead, I do see that... weird...
  • I did not change the installer file. The icons folder would need to be added.

I did this for my own needs, but I hope you find this useful.

…tions, as windows popups are pretty useless inside VR.

* Added a basic application icon and required resource settings.
* Added overlay icon showing HMD battery status at all times.
* Added icon files for the above.
* Disabled the sockets code (commented out) as it doesn't seem to work and denies connections.
@rhaamo
Copy link
Owner

rhaamo commented Sep 8, 2024

Hello,

Thanks for the PR !

  • I will separate the TTS notifications in their own setting and functions, as for the windows notifications they are useful at least to me when I do development involving the headset :D
  • Will look to incorporate the icons properly with the installer
  • For the socket code hmm, it won't connect when XSOverlay isn't launched, and it should be off by default, I will double check that with a default config it doesn't try to connect or something (it's my main notification usage as it shows them in the headset)
  • There is a weird thing with the overlay, if I don't put it at least one time in "front" on the desktop, it will be empty, I think there is something weird with IMGUI... I will probably disable the code to put the app in background on launch if that "fixes" it

Will look to do that when I got some time

@rhaamo rhaamo self-assigned this Sep 8, 2024
@uq1
Copy link
Author

uq1 commented Sep 8, 2024

No problems. Like I say, did these things for my own use, but figured I should share in case you wanted any of it.

I did leave some changes in the PR that was from trying to work out why the overlay did not show, but none of it should be active. You may need/want to remove the commented out stuff unless you want to try to work out what's going on there using it.

I did look into making it minimize to system tray, that may actually be a good idea as you could maybe also move to using windows notification system (balloon popups or the side bar) that way as well, instead of your own.

I however spent too many hours trying to figure out the reason for the overlay not showing to continue down that path, hehe. My best guess (hard to debug without adding a bunch of dependencies) is that imgui does not draw anything for some reason, maybe versions mismatch with ImGUI and GL3 libs. Even after commenting out the minimize command nothing shows up, makes me think the texture is simply blank coming out of GL3. Maybe just an older GL3 lib is all that is needed.

Oh, I also increased the max devices to 50 and allowed window scrolling, because standable/Virtual-Desktop can add a bunch, especially when you also have real trackers.

Anyway, hope some of this stuff helps. I have been trying to get FpsVR and Virtual Desktop to add these (any) notifications for well over a year without any success. Was happy to see your project while looking to make my own method hehe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants