Skip to content

Version 1.8.5
Compare
Choose a tag to compare
@AsparagusEduardo AsparagusEduardo released this 10 Jul 13:45
· 995 commits to master since this release
expansion/1.8.5
c0eb9af
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Learn about vigilant mode. 
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.5`.

🌋 IMPORTANT CHANGES AND REFACTORS 🌋

  • Small ABILITYEFFECT_MOVES_BLOCK refactor for readability by @AlexOn1ine in #4635
  • Removed redundant partnerPicId arguments in macros by @Bassoonian in #4736
  • Renamed some labels from "critical hit chance" to "critical hit odds" by @Sneed69 in #4751
    • sCriticalHitChance => sCriticalHitOdds.
    • GetCritHitChance => GetCritHitOdds.
  • Renamed BS_FAINTED_LINK_MULTIPLE_1/2 to BS_FAINTED_MULTIPLE_1/2 by @DizzyEggg in #4851
  • Remove Duplicate ai code from battle_ai_util.c by @AlexOn1ine in #4883
    • AI_CanBeBurned is now handled by CanBeBurned.
    • CanSleep renamed to CanBeSlept.
      • AI_CanSleep is now handled by CanBeSlept and added defAbility argument.
    • Added defAbility argument for CanBePoisoned.
    • Added defAbility argument for CanBeBurned.
    • Added defAbility argument for CanBeParalyzed.
  • Got rid of hardcoded stat raise anim values by @DizzyEggg in #4825
  • Added parentheses to SPECIES_EGG macro to avoid issues by @DizzyEggg in #4899
  • IsFinalStrikeEffect uses effect instead of move by @Sneed69 in #4917

💥 Softlock/Crash fixes 💥

  • Fixed Baton Pass hardlocking on Memento by @DizzyEggg in #4773
  • Fixed Revive in Double Battles causing a softlock by @DizzyEggg in #4784
  • Fixed Tectonic Rage causing a freeze after leveling up by @DizzyEggg in #4787
  • Fixed Smack Down's animation softlocking the game after around 13 uses by @DizzyEggg in #4774
  • Fixed softlock caused by using Covet/Thief on a Pokémon with Sticky Hold by @Sneed69 in #4885

🧬 General 🧬

Added

Fixed

  • Fixed Poké Ball inheritance into actually working by @cawtds in #4695
  • Daycare fixes by @Sneed69 in #4479
    • Fixed Evolved mons not copying moves as they do not have their own egg move table.
    • Fixed forms of the same species not copying egg moves from each other.
  • Fixed Roamer Frostbite status not carrying over between battles by @Sneed69 in #4822
  • Fixed Partners getting the wrong nature defined by @AlexOn1ine in #4926
  • Fixed Shop menu lists not properly displaying 6-digit item prices by @DizzyEggg in #4929

🐉 Pokémon 🐉

Changed

  • PokeCommunity sprites batch (May) by @kittenchilly in #4714
    • Pawmi (Front by KingOfThe-X-Roads, back by Vent, QC by leParagon)
    • Pawmo (By vent, qc by leParagon)
    • Okidogi (Front by KingOfThe-X-Roads + by leParagon, back by Lykeron + QC by Alexandrev2. 0)
    • Backported @hedara90's Terapagos from #4691
  • Updated wild held items to Gen 9 by @kittenchilly in #4769
    • Teddiursa (Common: None_> Honey)
    • Bisharp (Rare: None -> Leader's Crest)
    • All Oricorio: (Rare: Honey -> Corresponding Nectar)
    • Toedscool, Toedscruel: (Common: Tiny Mushroom, Rare: Big Mushroom)
    • All Paradox Mon: (Rare: Booster Energy)

Fixed

  • Fixed Tandemaus being able to evolve via Rare and Exp. Candies by @Bassoonian in #4759
  • Fixed Poltchageist not always producing Counterfeit form offspring by @kittenchilly in #4812
  • Fixed missing Minior Pokédex Entry by @cawtds in #4858
  • Multiple Pokemon sprite fixes by @cafei-uh in #4887
    • Fixed Charjabug shiny + cleaned up its front sprite
    • Changed Lurantis back sprite to better match its ingame model
    • Fixed Bounsweet shiny not changing the color of its lower body
    • Brightened the white color of Bruxish shiny + tweaked its sprites to accommodate the change
  • Fixed P_UPDATED_ABILITIES not reverting newly gained abilities in Gens 4/6/7 by @AsparagusEduardo in #4922

⚔️ Battle General ⚔️

Fixed

  • Fixed Dynamax HP not reverting upon fainting by @WillKolada in #4681
  • Fixed the partner's palette from shifting when throwing a Poké Ball by @Bassoonian in #4736
  • Fixed shiny value not being updated in battle, causing the palette to reset when reloading the sprites by @DizzyEggg in #4788
  • Fixed B_VAR_STARTING_STATUS every following terrains infinite by @DizzyEggg in #4795
  • Fixed Gen 7+ confusion self hurt chance from 1 in 3 to 33% by @Sneed69 in #4831
  • Fixed caught wild pokemon not restoring their used held item by @kittenchilly in #4803
  • Fixed AI's right slot switching-in too early by @DizzyEggg in #4851
  • Ported post-KO test improvements from closed PR by @AlexOn1ine in #4859
  • Fixed how switch-in effects are played out after multiple faints in the same turn by @DizzyEggg in #4864
  • Fixed Megas gaining abilities after fainting by @DizzyEggg in #4873

🤹 Moves 🤹

Fixed

  • Added missing ignoreSubstitute flags for Defog (only in Gen 4), Torment and Powder by @AlexOn1ine in #4623
  • Fixed Grassy Glide granting priority if it's converted to Max Move by @PhallenTree in #4659
  • Fixed Rampage moves not confusing the user if it's canceled by Protect and Type immunity by @Sneed69 in #4722
  • Fixed Tar shot the target always be to Fire regardless of existing types by @Sneed69 in #4756
  • Fixed Shell Side Arm by @AlexOn1ine in #4753
  • Fixed Body press using physical Defense stat changes instead of Sp. Defense stat stages in Wonder Room (still uses physical defense stat) by @DizzyEggg in #4792
  • Fixed Relic Song playing the transforming animation for species other than Meloetta by @DizzyEggg in #4799
  • Fixed Pursuit not being locked by Choice Items when used on an opponent switching out by @DizzyEggg in #4801
  • Fixed Encore's effect lasting only 2 turns if it was used after the opponent uses the move in the same turn by @DizzyEggg in #4802
  • Fixed Spectral Thief playing stat raise animation when the user has Contrary by @DizzyEggg in #4824
  • Fixed Fury Cutter scaling up to 640 power by @Sneed69 in #4846
  • Fixed moves with the ignoresTargetAbility flag ignoring the attacker's own ability by @Sneed69 in #4855
  • Fixed incorrect move names by @AlexOn1ine in #4854
    • Floral Healing
    • Jungle Healing
    • Oceanic Operetta
  • Fixed Grassy Terrain not healing on the final turn of its duration by @AlexOn1ine in #4903
  • Fixed Shed Tail's HP reduction rounding down instead of up by @kleeenexfeu in #4913
  • Fixed Bitter Malice's description, which used to imply that it didn't always lower the opponent's Attack by @kleeenexfeu in #4933
  • Fixed Flame Burst's adjacent damage not bypassing Substitute by @hedara90 in #4939

🎭 Abilities 🎭

Added

  • Added missing Gen 3-4 config for Lightning Rod/Storm Drain (B_REDIRECT_ABILITY_IMMUNITY) by @AsparagusEduardo in #4920

Fixed

  • Fixed Dancer issues @PhallenTree in #4638
    • Fixed Dancer triggering if the move user flinches when it was going to use a dance move
    • Fixed Dancer not triggering if a previous Dancer flinches.
  • Fixed Dazzling, Queenly Majesty and Armor Tail not protecting partners from priority moves by @AlexOn1ine in #4635
  • Fixed Burning Bulwark's incorrect message by @PhallenTree in #4659
  • Fixed Disguise's breakable flag (ignorable by Mold Breaker) by @AgustinGDLV in #4666
  • Fixed redundant call to IsBattlerWeatherAffected Dry Skin's checks by @Sneed69 in #4675
  • Fixed Guard Dog blocking U-Turn/Volt Switch/Flip Turn instead of Roar/Circle Throw/Dragon Tail by @PhallenTree in #4690
  • Fixed some abilities preventing stat dropping move effects when used on self by @Sneed69 in #4696
    • Hyper Cutter (Attack)
    • Big Pecks (Defense)
    • Keen Eye/Illuminate (Accuracy)
  • Fixed Mummy and Lingering Aroma not working at all by @Sneed69 in #4731
  • Fixed Berserk, Anger Shell, Wimp Out, Emergency Exit HP threshold (more than half HP instead of half HP and more) by @Sneed69 in #4724
  • Fixed Mycelium Might affecting every battler on the field instead of just the ability holder by @Sneed69 in #4740
  • Fixed Skill Link ignoring Gastro Acid/Neutralizing Gas by @Sneed69 in #4746
  • Fixed Own Tempo ignoring Gastro Acid/Neutralizing Gas when checking for Berserk Gene by @Sneed69 in #4746
  • Fixed Soul-Heart changing stats of wrong battler, which caused Mirror Herb to behave incorrectly by @DizzyEggg in #4785
  • Fixed Poison Touch trigger chance from 1 in 3 to 30% by @Sneed69 in #4831
  • Fixed Cursed Body trigger chance from 1 in 3 to 30% by @Sneed69 in #4831
  • Fixed Comatose not being supressed if it's obtained by a Pokémon Transforming by @DizzyEggg in #4852
  • Fixed Supersweet Syrup0s description by @AlexOn1ine in #4902

🧶 Items 🧶

Changed

  • Allowed rematches to occur if I_VS_SEEKER_CHARGING isn't enabled by @fdeblasio in #4866

Fixed

  • Fixed Honey altering tiles when used by @cawtds in #4703
  • Fixed potential undefined behaviour when using escape rope by @cawtds in #4705
  • Fixed Hyper Potion's price not respecting I_PRICE by @Bassoonian in #4737
  • Fixed Ability Shield not protecting against multiple effects by @Sneed69 in #4740
    • Mold Breaker-type abilities.
    • Mycelium Might.
    • Moves that bypass abilities (eg. Sunsteel Stike).

🤖 Battle AI 🤖

Changed

  • Add checks for EFFECT_POLTERGEIST and EFFECT_FIRST_TURN_ONLY to IsDamageMoveUnusable by @iriv24 in #4693

Fixed

  • Fixed AI going for speed control even when it's faster than the opponet by @AlexOn1ine in #4630
  • Fixed AI not considering EFFECT_RAGING_BULL similarly to EFFECT_BRICK_BREAK by @AsparagusEduardo in #4682
  • Fixed AI getting incorrect calculations due to using gCurrentMove in CalcCritChanceStageArgs by @AlexOn1ine in #4687
  • Fixed AI not recording Battle Armor or Shell Armor by @Sneed69 in #4751
  • Fixed AI not considering guaranteed crits by @Sneed69 in #4751
  • Fixed AI not properly avoiding contact against Rocky Helmet/Rough Skin by @Sneed69 in #4779
  • Fixed AI not recognising Volt Absorb/Flash Fire by @DizzyEggg in #4781
  • Fixed AI thinking that Defiant/Competitive triggers off partner's moves in doubles by @Sneed69 in #4786
  • Fixed AI using TRUE (Stench) when calculating if it's worth using Swagger or Flatter on its partner by @Sneed69 in #4786
  • Fixed passing hold effect instead of ability in one call of ShouldSetSandstorm by @Sneed69 in #4789

🧪 Test Runner 🧪

Added

  • Added FORCE_MOVE_ANIM macro to force an animation to run in headless mode by @DizzyEggg in #4774
    • Usage: FORCE_MOVE_ANIM(TRUE) at the beginning of the test and FORCE_MOVE_ANIM(FALSE) at the end.
  • Added test to prevent species from having different evolution tracker methods by @Bassoonian in #4771
  • Added test for missing Pokédex Entries by @cawtds in #4858
  • Added missing Move Effect TODO tests - Volume B by @AsparagusEduardo in #4682
  • Added missing tests
  • Added AI tests for avoiding using status moves on Pokémon with abilities that prevent them by @AlexOn1ine in #4883
  • Added Own Tempo/Mold Breaker test by @AlexOn1ine in #4883

Changed

  • Multiple changes by @AsparagusEduardo in #4682
    • Renamed some Baton Pass-related tests so that their prefix becomes Baton Pass.
      • Eg. Aqua Ring can be Baton Passed becomes Baton Pass passes Aqua Ring's effect.
    • Expanded Belch's test to show that it doesn't need to eat a berry before each use of the move.
    • Unconfirmed interactions added to the specific files.
    • Split EFFECT_RAGING_BULL from EFFECT_BRICK_BREAK's file.
    • Moved Grassy Terrain/Earthquake test to Earthquake file.
  • Write new/Fix old tests for post-ko switch scenarios by @DizzyEggg in #4856

Fixed

📦 Pret merges 📦

Full Changelog: expansion/1.8.4...expansion/1.8.5

Contributors

AsparagusEduardo, leo60228, and 18 other contributors
Assets 2
Loading