code cleanup

rfuzzo · May 31, 2024 · 006d37c · 006d37c
1 parent 09a6389
commit 006d37c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/gui/src/app.rs b/gui/src/app.rs
@@ -334,7 +334,7 @@ impl eframe::App for TemplateApp {
                                     self.plugin_filter = String::new();
                                 } else {
                                     // add notes to filter
-                                    self.plugin_filter = mod_name.clone();
+                                    self.plugin_filter.clone_from(mod_name);
                                 }
                             }
                         });
@@ -435,7 +435,7 @@ impl eframe::App for TemplateApp {
                         frame.frame.fill = bg_color;
 
                         // update hover filter
-                        self.plugin_hover_filter = w.get_plugins().clone();
+                        self.plugin_hover_filter.clone_from(&w.get_plugins());
                     } else {
                         self.plugin_hover_filter = vec![];
                     }

diff --git a/src/parser.rs b/src/parser.rs
@@ -457,9 +457,13 @@ impl Parser {
         let mut tokens: Vec<String> = vec![];
 
         // ignore everything after ;
-        let mut line = line.clone();
+        let line = line.clone();
         if line.contains(';') {
-            line = line.split(';').next().unwrap_or("").trim().to_owned();
+            line.split(';')
+                .next()
+                .unwrap_or("")
+                .trim()
+                .clone_into(&mut line.to_owned());
         }
 
         let mut is_quoted = false;

diff --git a/src/sorter.rs b/src/sorter.rs
@@ -135,8 +135,8 @@ impl Sorter {
                 for er in &err {
                     error!("cycles:");
                     for e in er {
-                        error!("\t{}: {}", e, index_dict_rev[&e]);
-                        res.push(index_dict_rev[&e].clone());
+                        error!("\t{}: {}", e, index_dict_rev[e]);
+                        res.push(index_dict_rev[e].clone());
                     }
                 }
 

diff --git a/tests/unit_rules_tests.rs b/tests/unit_rules_tests.rs
@@ -235,7 +235,7 @@ mod unit_tests {
     #[test]
     fn test_order_case() {
         {
-            let mods = vec![
+            let mods = [
                 "a.esp".to_string(),
                 "b.ESP".to_string(),
                 "c.esp".to_string(),