Update how APITestCase's client is set for django>=5.2 compatibility #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jefftriplett
approved these changes
Aug 8, 2025
jefftriplett
reviewed
Aug 8, 2025
|
|
||
| def setUp(self): | ||
| super(APITestCase, self).setUp() | ||
| api_client_class = get_api_client() |
There was a problem hiding this comment.
Just noting that api_client_class is a better name than we landed on.
|
Good catch and sorry we missed it. I strangely didn't get any errors with our 5.2 projects, but I'll cc @frankwiles to publish it. |
andres-holvi
force-pushed
the
fix-test-client
branch
from
3028f34 to
f4592c2
Compare
|
f-pushed to attempt to fix the linter issue |
|
When this can be merged? |
|
cc @frankwiles I missed my pypi invite so I need to resync with you sometime so I can cut releases and nag you less. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #215