Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the severity if the output is from shellcheck #153

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

massongit
Copy link
Contributor

.github/workflows/migration_on_demand.yml:160:9: shellcheck reported issue in this script: SC2086:<severity>:...

I fix to parse the severity of shellcheck output like the one above and add it to the beginning of the output, and then pass it to reviewdog.
This diff allows reviewdog to understand the severity of shellcheck.
The default severity is error.

@massongit massongit linked an issue Jan 12, 2025 that may be closed by this pull request
@massongit massongit requested a review from javierjulio January 12, 2025 06:46
Copy link

🏷️ [bumpr] Next version:v1.62.1 Changes:v1.62.0...reviewdog:massongit-patch-2

Copy link
Contributor

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

🏷️ [bumpr] Next version:v1.63.0 Changes:v1.62.0...reviewdog:massongit-patch-2

@HagegeR
Copy link

HagegeR commented Jan 12, 2025

so this should resolve #152 right? thanks!!

@massongit massongit merged commit 9be0e56 into main Jan 13, 2025
13 checks passed
@massongit massongit deleted the massongit-patch-2 branch January 13, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail_level not properly enforced
3 participants