Feat(cli) add install and uninstall command (Sourcery refactored)
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sourcery-ai
bot
force-pushed
the
sourcery/feat(cli)--add-`install`-and-`uninstall`-command
branch
from
73a2a25 to
d1b1ff9
Compare
sourcery-ai
bot
force-pushed
the
sourcery/feat(cli)--add-`install`-and-`uninstall`-command
branch
from
d1b1ff9 to
f0a91b8
Compare
HsiangNianian
deleted the
sourcery/feat(cli)--add-`install`-and-`uninstall`-command
branch
| models = {} | ||
| models["hola"] = joblib.load(join(HYDRO_DIR, "models", "hola.pkl")) | ||
| return models | ||
| return {"hola": joblib.load(join(HYDRO_DIR, "models", "hola.pkl"))} |
There was a problem hiding this comment.
Function _load_models refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-62
to
-64
| elif self.config.handle_group_message: | ||
| if self.event.message_type == "guild": | ||
| return self.str_match(match_str) |
There was a problem hiding this comment.
Function rule refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
Comment on lines
-155
to
+157
| else: | ||
| if len(rolls) > int(threshold): | ||
| return str(total) | ||
| rolls_str = " + ".join(str(r) for r in rolls) | ||
| result_str = ( | ||
| f"{total} = {rolls_str}" if is_reversed else f"{rolls_str} = {total}" | ||
| ) | ||
| return result_str | ||
| if len(rolls) > int(threshold): | ||
| return str(total) | ||
| rolls_str = " + ".join(str(r) for r in rolls) | ||
| return ( | ||
| f"{total} = {rolls_str}" if is_reversed else f"{rolls_str} = {total}" | ||
| ) |
There was a problem hiding this comment.
Function HydroDice.roll_dice refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #260 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
feat(cli)--add-`install`-and-`uninstall`-commandbranch, then run:Help us improve this pull request!