-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 feat(retext-german): add new package for parsing German natural language #95
The head ref may contain hidden characters: "\u{1F4E6}-feat(retext-german)"
Conversation
…guage 🔧 chore(retext-german): add .npmrc and tsconfig.json for package configuration 📝 docs(retext-german): add readme.md for package documentation 🎉 init(retext-german): create index.js and lib/index.js for initial package setup 🔧 chore(retext-german): add package.json for package metadata and dependencies
This comment has been minimized.
This comment has been minimized.
Hi Dennis, thanks for your work and your patience!
No, thank you. Seems like extra work that I cannot do (I am not a native german speakers), with no benefit: it’s open source, anyone can maintain anything. It looks like you copy/pasted a folder in there. That’s a good start, but doesn’t make everything workable. Line 12 in 0d7c168
Then you run npm install and npm test and such from there.
You are also currently getting type errors. I assume because For your new package Particularly the As for your error here: you are using yarn. Don’t use yarn, we use npm. From the root of the project run |
Ok will do it |
Thanks for the PR. Closing for now as this cannot land currently and there seems to be no activity. I recommend just publishing and maintaining this yourself! I don’t need to do all the work. It’s open source. Others can do work too! |
Initial checklist
Description of changes
Hi I created this because I need it for a project and thought so you can extend the whole thing with a language. 😊
I also had to create a german-parser for it which I also just adapted from yours. I would also like to give you the repository if you want. you can find it here: https://github.com/nyxb/parse-german. It takes into account the german spelling as well as umlauts etc.
🔧 chore(retext-german): add .npmrc and tsconfig.json for package configuration
📝 docs(retext-german): add readme.md for package documentation
🎉 init(retext-german): create index.js and lib/index.js for initial package setup
🔧 chore(retext-german): add package.json for package metadata and dependencies