Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more lgbtq notes; fix a few existing ones #87

Closed
wants to merge 4 commits into from

Conversation

riley-martine
Copy link
Contributor

@riley-martine riley-martine commented Oct 25, 2019

Ref: get-alex/alex#219

Questions:

  • Should I bump the minor version?
  • Should there be tests for this?
  • Even though the style guide lists sexual reassignment surgery as an alternative to sex change, that term has fallen out of vogue. Should it be removed?
  • Could there be a preferred structure for notes? e.g. should they all end in a period, should they avoid all starting with "Avoid" or "This word"?
  • Should I squash commits?

@riley-martine riley-martine changed the title Lgbtq notes Add more lgbtq notes; fix a few existing ones Oct 25, 2019
@codecov-io

This comment has been minimized.

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you check these suggestions though?

  • Should I bump the minor version?

Nope, we’ll do that when it is released.

  • Should there be tests for this?

We don’t need to check notes (we typically check new rules though)

  • Even though the style guide lists sexual reassignment surgery as an alternative to sex change, that term has fallen out of vogue. Should it be removed?

I don‘t know! But if that term is no longer in favour, it should be warned about. I’m sure you are right, but do you have a source for that?

  • Could there be a preferred structure for notes? e.g. should they all end in a period, should they avoid all starting with "Avoid" or "This word"?

I’d stay stick with what’s there (but that is a bit all over the place). I should standardise them and write some docs for that 🤔

  • Should I squash commits?

Nope, GH does that!

considerate:
- bisexual
inconsiderate:
- bi
- type: simple
source: https://www.glaad.org/reference/style
note: "\"Homosexual\" has a clinical history and is used to imply LGBTQ+ people are diseased or psychologically/emotionally disordered"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: "\"Homosexual\" has a clinical history and is used to imply LGBTQ+ people are diseased or psychologically/emotionally disordered"
note: "`Homosexual` has a clinical history and is used to imply LGBTQ+ people are diseased or psychologically/emotionally disordered"

considerate:
- cross-dresser
inconsiderate:
- transvestite
- type: simple
source: https://www.glaad.org/reference/transgender
note: Avoid overemphasizing surgery when discussing transgender people or the process of transition - it's not a necessary component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: Avoid overemphasizing surgery when discussing transgender people or the process of transition - it's not a necessary component.
note: Avoid overemphasizing surgery when discussing transgender people or the process of transition - its not a necessary component

inconsiderate:
- sexchange
- sex change
- type: simple
source: https://www.glaad.org/reference/transgender
note: Shift focus away from the assigned sex and towards the identified gender. Also, disentangle "truly becoming" another gender from the procedures one may choose.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: Shift focus away from the assigned sex and towards the identified gender. Also, disentangle "truly becoming" another gender from the procedures one may choose.
note: Shift focus away from the assigned sex and towards the identified gender. Also, disentangle truly becoming another gender from the procedures one may choose

considerate:
- transgender
inconsiderate:
- transgendered
- type: simple
source: https://www.glaad.org/reference/transgender
note: This is a term used by anti-transgender activists to dehumanize transgender people and reduce who they are to "a condition."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: This is a term used by anti-transgender activists to dehumanize transgender people and reduce who they are to "a condition."
note: This is a term used by anti-transgender activists to dehumanize transgender people and reduce who they are to a condition

@@ -147,13 +156,15 @@
- genetically female
- type: simple
source: https://www.glaad.org/reference/transgender
note: A term created and used by far-right extremists to oppose nondiscrimination laws that protect transgender people.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: A term created and used by far-right extremists to oppose nondiscrimination laws that protect transgender people.
note: A term created and used by far-right extremists to oppose nondiscrimination laws that protect transgender people

considerate:
- non-discrimination law
- non-discrimination ordinance
inconsiderate:
- bathroom bill
- type: simple
source: http://www.isna.org/node/979
note: These terms are stigmatizing to patients and their families. Intersex status is more complicated than the mere presence or absence of certain gonadal tissues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: These terms are stigmatizing to patients and their families. Intersex status is more complicated than the mere presence or absence of certain gonadal tissues.
note: These terms are stigmatizing to patients and their families because intersex status is more complicated than the mere presence or absence of certain gonadal tissues

@@ -162,6 +173,7 @@
- pseudo hermaphroditic
- type: simple
source: http://www.isna.org/node/979
note: These terms are stigmatizing to patients and their families. Intersex status is more complicated than the mere presence or absence of certain gonadal tissues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: These terms are stigmatizing to patients and their families. Intersex status is more complicated than the mere presence or absence of certain gonadal tissues.
note: These terms are stigmatizing to patients and their families because intersex status is more complicated than the mere presence or absence of certain gonadal tissues

@@ -172,7 +184,7 @@
- pseudo hermaphrodite
- type: simple
source: https://www.reddit.com/r/asktransgender/comments/23wbq1/is_the_term_shemale_seen_as_offensive/
note: Transgender people prefer to be called by their chosen pronouns. If you're confused, just ask what pronouns they prefer.
note: This word dehumanizes transgender people.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: This word dehumanizes transgender people.
note: This word dehumanizes transgender people

@wooorm
Copy link
Member

wooorm commented Nov 3, 2019

@riley-martine Ping!

@riley-martine
Copy link
Contributor Author

sorry! been busy, will get to soon

@wooorm
Copy link
Member

wooorm commented Dec 1, 2019

@riley-martine Ping!

@wooorm wooorm closed this in f704caa Jan 15, 2020
@wooorm
Copy link
Member

wooorm commented Jan 15, 2020

Thanks for your work on this, Riley! I applied the suggestions and released them as 4.5.0!

@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Jan 15, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants