-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a couple more notes and modifications & modified the tests to accommodate them #49
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a5f0701
Added a whole lot of notes
AhmedRedaAmin 829f414
modified some tests to accomodate changes
AhmedRedaAmin 462b3a1
some tests were still failing -fixed
AhmedRedaAmin ca727c1
removed upper case & non-offensive words
AhmedRedaAmin 5055b34
fixed merge conflicts
AhmedRedaAmin 085469d
Merge branch 'master' into master
AhmedRedaAmin e597a47
Merge branch 'master' into master
AhmedRedaAmin 98b64b8
Update test.js
AhmedRedaAmin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what was the reason to add skinny here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well , good question , the thing is , skinny comes from a description that someone is "skin on bones" which is used to reference people in late stages of starvation , though of course recently it has been normalized in day to day English as a casual word , however, if we are to level this description at someone who actually has anorexia for example , I thought it sounded inconsiderate in that context , or you know , I could just be overthinking this :'D.
But yeah , here is how my thought process went for both "bony" and "skinny" .
Anyways , I'll be removing skinny now .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also concerning the upper case in
race.yml
, I just capitalized the races ,regions , nationalities and whatnot , I wasn't aware the tooling puts everything to lower case(or uppercase) before matching , so I 'll be on it 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally , it's my pleasure , mate ! 👍