Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review & update Working Agreement #15

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

atxryan
Copy link
Member

@atxryan atxryan commented Feb 13, 2024

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

Review and update Working Agreement.

Does this introduce a breaking change

  • YES
  • NO

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

  • Closes #issue_number (this will automatically close the issue when the PR closes)
  • References #issue_number (this references the issue but does not close with PR)

@atxryan atxryan marked this pull request as ready for review February 13, 2024 19:05
@atxryan atxryan changed the title Add communication styles Review & update Working Agreement Feb 13, 2024
@atxryan
Copy link
Member Author

atxryan commented Feb 13, 2024

I think it makes sense to move the Engineering details to the EngineeringPractices.md file. I suggest keeping the Working Agreement broadly focused on people, culture, and communication while Engineering Practices can include details about team agreements on tech styles and policies.

@atxryan atxryan requested a review from Zeriet February 13, 2024 22:07
@atxryan atxryan marked this pull request as draft February 13, 2024 22:07
@atxryan atxryan self-assigned this Feb 13, 2024

- We will estimate User Stories with size tagging to help gauge how much work we commit to within a sprint.
- We will use T-shirts sizing for our estimation -- with XS <1 day, Small is 1-2 days, Medium is 2-3 days, Large is 4-5 days, and XL > week, needs decomposed.
Sharing is caring. We will record demos to share early and share often. We will share as we go and not wait until the end of the project.

### Ceremonies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to rotate Scrum Master weekly?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure on that, that could be a good discussion for the offsite meeting though.

@Zeriet
Copy link

Zeriet commented Feb 13, 2024

Thanks @atxryan, some additional points that could be up for discussion:

Conflict resolution:
Defining a process for resolving conflicts within the team.

Inclusion and diversity:
Determining how the team can actively promote diversity and inclusion.

Customer Feedback:
Implementing a regular process for gathering and incorporating customer feedback into the development cycle.

@atxryan
Copy link
Member Author

atxryan commented Feb 14, 2024

I also asked ChatGPT to analyze the Working Agreement and offer suggestions for improvement and additions. Let's discuss these at the offsite.

image

@atxryan atxryan requested a review from a team February 15, 2024 15:04
@TBunkley
Copy link

@atxryan I think it would be a good idea to comment on leveraging something like codespaces as a good engineering practice. Developers can lose alot of time on configuration / setup tasks and codespace can optimize it.

@TBunkley
Copy link

We also may want to add something about committing code frequently to our work branches. We can emphasize it's more about saving the current state of your code vs a meter for mgmt to check for progress.

@@ -1,5 +1,41 @@
# Engineering Practices

## How we code together

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something dev environment consistency? Here is a suggestion.

Suggested change
### Development Environment Onboarding Consistency
- To promote consistency and reduce onboarding time, Github Codespaces should be preferred.
- The codespace should be maintained by the engineering team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants