Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden kill invocation test for the the three node setup #21

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Harden kill invocation test for the the three node setup #21

merged 1 commit into from
Nov 13, 2024

Conversation

tillrohrmann
Copy link
Contributor

@tillrohrmann tillrohrmann commented Nov 13, 2024 •
edited
Loading

Harden kill invocation test for the the three node setup. In order to tolerate leadership changes, we need to make the startCallTree idempotent.

slinkydeveloper
slinkydeveloper approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, seems like i forgot it when adding idempotency id everywhere

@tillrohrmann tillrohrmann merged commit 20a15c2 into restatedev:main Nov 13, 2024
2 checks passed
@tillrohrmann tillrohrmann deleted the harden-kill-invocation branch November 13, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillrohrmann @slinkydeveloper